Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 10800019: Refactor ContentShell to remove ContentViewClient dependency. (Closed)

Created:
8 years, 5 months ago by Ted C
Modified:
8 years, 5 months ago
Reviewers:
joth, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Refactor ContentShell to remove ContentViewClient dependency. The ContentViewClient was replacing the native Shell as the WebContents delegate, which is being refactored to no longer provide this functionality. This moves all the dependencies into Shell (like other platforms) and removes the need for the native shell_view.cc/h. Now all calls are routed through shell_android. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -364 lines) Patch
M content/content_shell.gypi View 3 chunks +10 lines, -5 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java View 4 chunks +6 lines, -6 lines 0 comments Download
A + content/shell/android/java/src/org/chromium/content_shell/Shell.java View 6 chunks +23 lines, -45 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ShellManager.java View 2 chunks +7 lines, -7 lines 0 comments Download
D content/shell/android/java/src/org/chromium/content_shell/ShellView.java View 1 chunk +0 lines, -209 lines 0 comments Download
M content/shell/android/javatests/src/org/chromium/content_shell/ContentShellUrlTest.java View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/res/layout/shell_view.xml View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/android/shell_library_loader.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/shell/android/shell_manager.h View 1 chunk +4 lines, -3 lines 0 comments Download
M content/shell/android/shell_manager.cc View 2 chunks +3 lines, -4 lines 0 comments Download
D content/shell/android/shell_view.h View 1 chunk +0 lines, -40 lines 0 comments Download
D content/shell/android/shell_view.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M content/shell/shell.h View 4 chunks +8 lines, -2 lines 0 comments Download
M content/shell/shell_android.cc View 3 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ted C
@jam for content_shell.gypi and content/shell/shell changes @joth for content/shell/android changes
8 years, 5 months ago (2012-07-18 18:53:08 UTC) #1
joth
lgtm
8 years, 5 months ago (2012-07-18 19:55:30 UTC) #2
jam
lgtm
8 years, 5 months ago (2012-07-18 20:26:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10800019/1
8 years, 5 months ago (2012-07-18 20:40:08 UTC) #4
commit-bot: I haz the power
Try job failure for 10800019-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-18 21:54:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10800019/1
8 years, 5 months ago (2012-07-18 22:59:10 UTC) #6
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 00:32:06 UTC) #7
Change committed as 147357

Powered by Google App Engine
This is Rietveld 408576698