[Mac] Changes to the behavior of Lion+ fullscreen and presentation mode.

[Mac] Changes to the behavior of Lion+ fullscreen and presentation mode.

This removes the sticky preference and instead makes the two keyboard shortcuts
each toggle the respective mode, such that hitting the same shortcut twice will
always exit that mode (making the actions symmetric). Diagram:
https://docs.google.com/open?id=0B4kReKV-OI17Y1lscGhISEtCYjg

After this CL, the only operation that does not work is entering Lion FS mode
from presentation mode. Using that shortcut exits fullscreen. That will be
addressed in a followup CL.

BUG=114373
TEST=Perform operations in diagram. All work except Presentation->FS mode.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147921

[rohitrao (ping after 24h), 2012-07-22 11:50:44]

lgtm

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
chrome/browser/ui/cocoa/browser_window_controller.mm:2033:
enteringPresentationMode_ = presentationMode;
This seems a little silly inside an if (presentationMode) block.  Just always
set it to YES?

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:815: BOOL mode =
enteringPresentationMode_ ||
Is this variable basically replacing the functionality of
shouldUsePresentationModeWhenEnteringFullscreen?

[Robert Sesek, 2012-07-23 17:57:53]

Thanks!

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
File chrome/browser/ui/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
chrome/browser/ui/cocoa/browser_window_controller.mm:2033:
enteringPresentationMode_ = presentationMode;
On 2012/07/22 11:50:44, rohitrao wrote:
> This seems a little silly inside an if (presentationMode) block.  Just always
> set it to YES?

Done.

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

http://codereview.chromium.org/10800011/diff/1/chrome/browser/ui/cocoa/browse...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:815: BOOL mode =
enteringPresentationMode_ ||
On 2012/07/22 11:50:44, rohitrao wrote:
> Is this variable basically replacing the functionality of
> shouldUsePresentationModeWhenEnteringFullscreen?

Yes. I switched it to an ivar because there's also enteringFullscreen_;

[commit-bot: I haz the power, 2012-07-23 17:58:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/10800011/6001

[commit-bot: I haz the power, 2012-07-23 20:31:32]

Change committed as 147921