Hide names of internal classes from the user by mapping them to the documented

runtime/vm/class_finalizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/class_finalizer.h"
 
 #include "vm/flags.h"
 #include "vm/heap.h"
 #include "vm/isolate.h"
 #include "vm/longjump.h"
@@ skipping 178 matching lines @@
   if (FLAG_trace_class_finalization) {
     OS::Print("VerifyBootstrapClasses START.\n");
   }
   ObjectStore* object_store = Isolate::Current()->object_store();
 
   Class& cls = Class::Handle();
 #if defined(DEBUG)
   // Basic checking.
   cls = object_store->object_class();
   ASSERT(Instance::InstanceSize() == cls.instance_size());
+  cls = object_store->integer_implementation_class();
+  ASSERT(Integer::InstanceSize() == cls.instance_size());
   cls = object_store->smi_class();
   ASSERT(Smi::InstanceSize() == cls.instance_size());
+  cls = object_store->mint_class();
+  ASSERT(Mint::InstanceSize() == cls.instance_size());
+  cls = object_store->bigint_class();
+  ASSERT(Bigint::InstanceSize() == cls.instance_size());
   cls = object_store->one_byte_string_class();
   ASSERT(OneByteString::InstanceSize() == cls.instance_size());
   cls = object_store->two_byte_string_class();
   ASSERT(TwoByteString::InstanceSize() == cls.instance_size());
   cls = object_store->four_byte_string_class();
   ASSERT(FourByteString::InstanceSize() == cls.instance_size());
   cls = object_store->external_one_byte_string_class();
   ASSERT(ExternalOneByteString::InstanceSize() == cls.instance_size());
   cls = object_store->external_two_byte_string_class();
   ASSERT(ExternalTwoByteString::InstanceSize() == cls.instance_size());
   cls = object_store->external_four_byte_string_class();
   ASSERT(ExternalFourByteString::InstanceSize() == cls.instance_size());
   cls = object_store->double_class();
   ASSERT(Double::InstanceSize() == cls.instance_size());
-  cls = object_store->mint_class();
-  ASSERT(Mint::InstanceSize() == cls.instance_size());
-  cls = object_store->bigint_class();
-  ASSERT(Bigint::InstanceSize() == cls.instance_size());
   cls = object_store->bool_class();
   ASSERT(Bool::InstanceSize() == cls.instance_size());
   cls = object_store->array_class();
   ASSERT(Array::InstanceSize() == cls.instance_size());
   cls = object_store->immutable_array_class();
   ASSERT(ImmutableArray::InstanceSize() == cls.instance_size());
   cls = object_store->uint8_array_class();
   ASSERT(Uint8Array::InstanceSize() == cls.instance_size());
   cls = object_store->int16_array_class();
   ASSERT(Int16Array::InstanceSize() == cls.instance_size());
@@ skipping 99 matching lines @@
     ReportError(script, cls.token_pos(),
                 "class '%s' and superclass '%s' are not "
                 "both classes or both interfaces",
                 class_name.ToCString(),
                 super_class_name.ToCString());
   }
   // If cls belongs to core lib or to core lib's implementation, restrictions
   // about allowed interfaces are lifted.
   if ((cls.library() != Library::CoreLibrary()) &&
       (cls.library() != Library::CoreImplLibrary())) {
-    // Prevent extending core implementation classes Bool, Double, ObjectArray,
-    // ImmutableArray, GrowableObjectArray, IntegerImplementation, Smi, Mint,
-    // BigInt, OneByteString, TwoByteString, FourByteString.
-    ObjectStore* object_store = Isolate::Current()->object_store();
-    const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
-    const String& integer_implementation_name =
-        String::Handle(String::NewSymbol("IntegerImplementation"));
-    const Class& integer_implementation_class =
-        Class::Handle(core_impl_lib.LookupClass(integer_implementation_name));
-    const String& growable_object_array_name =
-        String::Handle(String::NewSymbol("GrowableObjectArray"));
-    const Class& growable_object_array_class =
-        Class::Handle(core_impl_lib.LookupClass(growable_object_array_name));
-    if ((super_class.raw() == object_store->bool_class()) ||
-        (super_class.raw() == object_store->double_class()) ||
-        (super_class.raw() == object_store->array_class()) ||
-        (super_class.raw() == object_store->immutable_array_class()) ||
-        (super_class.raw() == growable_object_array_class.raw()) ||
-        (super_class.raw() == object_store->int8_array_class()) ||
-        (super_class.raw() == object_store->uint8_array_class()) ||
-        (super_class.raw() == object_store->int16_array_class()) ||
-        (super_class.raw() == object_store->uint16_array_class()) ||
-        (super_class.raw() == object_store->int32_array_class()) ||
-        (super_class.raw() == object_store->uint32_array_class()) ||
-        (super_class.raw() == object_store->int64_array_class()) ||
-        (super_class.raw() == object_store->uint64_array_class()) ||
-        (super_class.raw() == object_store->float32_array_class()) ||
-        (super_class.raw() == object_store->float64_array_class()) ||
-        (super_class.raw() == object_store->external_int8_array_class()) ||
-        (super_class.raw() == object_store->external_uint8_array_class()) ||
-        (super_class.raw() == object_store->external_int16_array_class()) ||
-        (super_class.raw() == object_store->external_uint16_array_class()) ||
-        (super_class.raw() == object_store->external_int32_array_class()) ||
-        (super_class.raw() == object_store->external_uint32_array_class()) ||
-        (super_class.raw() == object_store->external_int64_array_class()) ||
-        (super_class.raw() == object_store->external_uint64_array_class()) ||
-        (super_class.raw() == object_store->external_float32_array_class()) ||
-        (super_class.raw() == object_store->external_float64_array_class()) ||
-        (super_class.raw() == integer_implementation_class.raw()) ||
-        (super_class.raw() == object_store->smi_class()) ||
-        (super_class.raw() == object_store->mint_class()) ||
-        (super_class.raw() == object_store->bigint_class()) ||
-        (super_class.raw() == object_store->one_byte_string_class()) ||
-        (super_class.raw() == object_store->two_byte_string_class()) ||
-        (super_class.raw() == object_store->four_byte_string_class())) {
-      const Script& script = Script::Handle(cls.script());
-      ReportError(script, cls.token_pos(),
-                  "'%s' is not allowed to extend '%s'",
-                  String::Handle(cls.Name()).ToCString(),
-                  String::Handle(super_class.Name()).ToCString());
+    // Prevent extending core implementation classes.
+    switch (super_class.id()) {
+      case kInteger:
+      case kSmi:
+      case kMint:
+      case kBigint:
+      case kDouble:
+      case kOneByteString:
+      case kTwoByteString:
+      case kFourByteString:
+      case kExternalOneByteString:
+      case kExternalTwoByteString:
+      case kExternalFourByteString:
+      case kBool:
+      case kArray:
+      case kImmutableArray:
+      case kGrowableObjectArray:
+      case kInt8Array:
+      case kExternalInt8Array:
+      case kUint8Array:
+      case kExternalUint8Array:
+      case kInt16Array:
+      case kExternalInt16Array:
+      case kUint16Array:
+      case kExternalUint16Array:
+      case kInt32Array:
+      case kExternalInt32Array:
+      case kUint32Array:
+      case kExternalUint32Array:
+      case kInt64Array:
+      case kExternalInt64Array:
+      case kUint64Array:
+      case kExternalUint64Array:
+      case kFloat32Array:
+      case kExternalFloat32Array:
+      case kFloat64Array:
+      case kExternalFloat64Array: {
+        const Script& script = Script::Handle(cls.script());
+        ReportError(script, cls.token_pos(),
+                    "'%s' is not allowed to extend '%s'",
+                    String::Handle(cls.Name()).ToCString(),
+                    String::Handle(super_class.Name()).ToCString());
+        break;
+      }
+      default: break;
     }
   }
   return;
 }
 
 
 void ClassFinalizer::ResolveFactoryClass(const Class& interface) {
   ASSERT(interface.is_interface());
   if (interface.is_finalized() ||
       !interface.HasFactoryClass() ||
@@ skipping 247 matching lines @@
 
   // At this point, we can only have a parameterized_type.
   const Type& parameterized_type = Type::Cast(type);
 
   if (parameterized_type.IsBeingFinalized()) {
     // Self reference detected. The type is malformed.
     FinalizeMalformedType(
         Error::Handle(),  // No previous error.
         cls, parameterized_type, finalization,
         "type '%s' illegally refers to itself",
-        String::Handle(parameterized_type.Name()).ToCString());
+        String::Handle(parameterized_type.UserVisibleName()).ToCString());
     return parameterized_type.raw();
   }
 
   // Mark type as being finalized in order to detect illegal self reference.
   parameterized_type.set_is_being_finalized();
 
   // The type class does not need to be finalized in order to finalize the type,
   // however, it must at least be resolved (this was done as part of resolving
   // the type itself, a precondition to calling FinalizeType).
   // Also, the interfaces of the type class must be resolved and the type
@@ skipping 13 matching lines @@
     intptr_t num_arguments = arguments.Length();
     AbstractType& type_argument = AbstractType::Handle();
     for (intptr_t i = 0; i < num_arguments; i++) {
       type_argument = arguments.TypeAt(i);
       type_argument = FinalizeType(cls, type_argument, finalization);
       if (type_argument.IsMalformed()) {
         // In production mode, malformed type arguments are mapped to Dynamic.
         // In checked mode, a type with malformed type arguments is malformed.
         if (FLAG_enable_type_checks) {
           const Error& error = Error::Handle(type_argument.malformed_error());
-          const String& type_name = String::Handle(parameterized_type.Name());
+          const String& type_name =
+              String::Handle(parameterized_type.UserVisibleName());
           FinalizeMalformedType(error, cls, parameterized_type, finalization,
                                 "type '%s' has malformed type argument",
                                 type_name.ToCString());
           return parameterized_type.raw();
         } else {
           type_argument = Type::DynamicType();
         }
       }
       arguments.SetTypeAt(i, type_argument);
     }
   }
 
   // The finalized type argument vector needs num_type_arguments types.
   const intptr_t num_type_arguments = type_class.NumTypeArguments();
   // The type class has num_type_parameters type parameters.
   const intptr_t num_type_parameters = type_class.NumTypeParameters();
 
   // Initialize the type argument vector.
   // Check the number of parsed type arguments, if any.
   // Specifying no type arguments indicates a raw type, which is not an error.
   // However, type parameter bounds are checked below, even for a raw type.
   if (!arguments.IsNull() && (arguments.Length() != num_type_parameters)) {
     // Wrong number of type arguments. The type is malformed.
     FinalizeMalformedType(
         Error::Handle(),  // No previous error.
         cls, parameterized_type, finalization,
         "wrong number of type arguments in type '%s'",
-        String::Handle(parameterized_type.Name()).ToCString());
+        String::Handle(parameterized_type.UserVisibleName()).ToCString());
     return parameterized_type.raw();
   }
   // The full type argument vector consists of the type arguments of the
   // super types of type_class, which may be initialized from the parsed
   // type arguments, followed by the parsed type arguments.
   TypeArguments& full_arguments = TypeArguments::Handle();
   if (num_type_arguments > 0) {
     // If no type arguments were parsed and if the super types do not prepend
     // type arguments to the vector, we can leave the vector as null.
     if (!arguments.IsNull() || (num_type_arguments > num_type_parameters)) {
@@ skipping 60 matching lines @@
       // The type argument vector of the type is not within bounds. The type
       // is malformed. Prepend malformed_error to new malformed type error in
       // order to report both locations.
       // Note that malformed bounds never result in a compile time error, even
       // in checked mode. Therefore, overwrite finalization with kFinalize
       // when finalizing the malformed type.
       FinalizeMalformedType(
           malformed_error,
           cls, parameterized_type, kFinalize,
           "type arguments of type '%s' are not within bounds",
-          String::Handle(parameterized_type.Name()).ToCString());
+          String::Handle(parameterized_type.UserVisibleName()).ToCString());
       return parameterized_type.raw();
     }
   }
 
   // If the type class is a signature class, we are currently finalizing a
   // signature type, i.e. finalizing the result type and parameter types of the
   // signature function of this signature type.
   // We do this after marking this type as finalized in order to allow a
   // function type to refer to itself via its parameter types and result type.
   if (type_class.IsSignatureClass()) {
@@ skipping 696 matching lines @@
 void ClassFinalizer::ReportError(const char* format, ...) {
   va_list args;
   va_start(args, format);
   const Error& error = Error::Handle(
       Parser::FormatError(Script::Handle(), -1, "Error", format, args));
   va_end(args);
   ReportError(error);
 }
 
 }  // namespace dart