Issue 10799018: gdrive: Get JSON feeds parsing off the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10799018: gdrive: Get JSON feeds parsing off the UI thread. (Closed)

Created:
8 years, 5 months ago by yoshiki

Modified:
8 years, 5 months ago

Reviewers:
hashimoto

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdrive: Get JSON feeds parsing off the UI thread. BUG=128378 TEST=GDataOperationsTest.GetDataOperationParseJson passes.

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+283 lines, -35 lines)			Patch
chrome/browser/chromeos/gdata/gdata_operations.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
chrome/browser/chromeos/gdata/gdata_operations.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
chrome/browser/chromeos/gdata/gdata_operations_unittest.cc	View	1 chunk	+179 lines, -0 lines	0 comments	Download
chrome/browser/chromeos/gdata/operations_base.h	View	2 chunks	+12 lines, -3 lines	0 comments	Download
chrome/browser/chromeos/gdata/operations_base.cc	View	4 chunks	+85 lines, -29 lines	0 comments	Download
chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yoshiki

hashimoto: Could you take a look? This is almost same as https://chromiumcodereview.appspot.com/10749015. The differences are ...

8 years, 5 months ago (2012-07-19 02:50:41 UTC) #1

hashimoto

On 2012/07/19 02:50:41, yoshiki wrote: > hashimoto: Could you take a look? This is almost ...

8 years, 5 months ago (2012-07-19 02:54:21 UTC) #2

yoshiki

8 years, 5 months ago (2012-07-19 02:56:34 UTC) #3

https://chromiumcodereview.appspot.com/10808027/

On 2012/07/19 02:54:21, hashimoto wrote:
> On 2012/07/19 02:50:41, yoshiki wrote:
> > hashimoto: Could you take a look? This is almost same as
> > https://chromiumcodereview.appspot.com/10749015.
> > 
> > The differences are merging to ToT and resolving memory leak on unittest,
> adding
> > 6 "delete"s at the end of test on gdata_operations_unittest.cc.
> 
> Could you try uploading the patch set again?
> Side-by-side diffs page says "error: old chunk mismatch" and shows nothing.

Expand Messages | Collapse Messages