Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 10798011: views: Add a cross-platform SelectFileDialogExtension API. (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 5 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

views: Add a cross-platform SelectFileDialogExtension API. To be used by chromeos, so it doesn't need to depend on views/ directly BUG=125846 R=ben@chromium.org

Patch Set 1 #

Patch Set 2 : add cross-platform SelectFileDialogExtension API #

Patch Set 3 : break the dependency in views file #

Patch Set 4 : include the cross-platform file in the views file #

Patch Set 5 : separate the cross from the specific #

Patch Set 6 : move them to the right place #

Patch Set 7 : rename to SelectFileDialogExtensionViews #

Patch Set 8 : fixes #

Patch Set 9 : #

Patch Set 10 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+925 lines, -14 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_list.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/select_file_dialog_extension.h View 1 1 chunk +34 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension_factory.cc View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_views.h View 1 2 3 4 5 6 7 1 chunk +120 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_views.cc View 1 2 3 4 5 6 7 8 1 chunk +352 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_views_browsertest.cc View 1 chunk +345 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/select_file_dialog_extension_views_unittest.cc View 1 2 3 4 5 6 1 chunk +60 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 7 8 9 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -3 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698