Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 10798010: Uses gyp "rules" rather than "actions" templates for the JNI generator. (Closed)

Created:
8 years, 5 months ago by bulach
Modified:
8 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, erikwright (departed), jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Uses gyp "rules" rather than "actions" templates for the JNI generator. This allow finer grain control over what is rebuilt. Also, since we have approval over the generated header file name, it greatly simplifies both the generator and also all the gyp files as they no longer need to list the header file and keep in sync with the java file, so the process now is as simple as adding a single java file to the sources. BUG=137069 TEST=build on android Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147515

Patch Set 1 #

Patch Set 2 : Rebased and added chrome_browser.gypi #

Patch Set 3 : Typo on content_jni.gypi #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -305 lines) Patch
M base/android/build_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/jni_generator/jni_generator.gyp View 1 chunk +6 lines, -18 lines 0 comments Download
M base/android/jni_generator/jni_generator.py View 1 1 chunk +53 lines, -81 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 1 chunk +0 lines, -13 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/locale_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/android/path_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/base.gyp View 1 1 chunk +7 lines, -12 lines 0 comments Download
M base/message_pump_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M build/jni_generator.gypi View 1 chunk +42 lines, -40 lines 0 comments Download
M chrome/browser/android/process_utils.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +4 lines, -6 lines 0 comments Download
M content/app/android/content_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/library_loader_hooks.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/sandboxed_process_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/app/android/user_agent.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/android_browser_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/content_view_statics.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/download_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/remote_debugging_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/sandboxed_process_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/touch_point.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/device_orientation/data_fetcher_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/geolocation/location_api_adapter_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/command_line.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/device_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/surface_callback.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/surface_texture_listener.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/android/trace_event_binding.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_jni.gypi View 1 2 1 chunk +24 lines, -46 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +5 lines, -8 lines 0 comments Download
M content/shell/android/shell_manager.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_android.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/media_player_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/media.gyp View 2 chunks +12 lines, -19 lines 0 comments Download
M net/android/network_change_notifier_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/android/network_library.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +6 lines, -10 lines 0 comments Download
M net/proxy/proxy_config_service_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test.gyp View 2 chunks +7 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
bulach
yfriedman: would you mind a sanity check before sending out to the respective owners please?
8 years, 5 months ago (2012-07-18 14:06:32 UTC) #1
Yaron
lgtm I think this definitely fits the bill for TBRing as aside from the jni-generator ...
8 years, 5 months ago (2012-07-18 15:18:33 UTC) #2
bulach
+mark, rsleevi thanks yaron! mark, ryan: these changes are a sort of follow up from: ...
8 years, 5 months ago (2012-07-18 16:01:31 UTC) #3
Mark Mentovai
LGTM
8 years, 5 months ago (2012-07-18 16:07:27 UTC) #4
Ryan Sleevi
lgtm. Thanks for doing this.
8 years, 5 months ago (2012-07-18 23:21:15 UTC) #5
bulach
thanks all! +jam: owners approval for content (mechanical changes) +satish: owners approval for content/shell/android (mechanical ...
8 years, 5 months ago (2012-07-19 07:54:51 UTC) #6
Satish
content/shell/android lgtm
8 years, 5 months ago (2012-07-19 08:27:09 UTC) #7
jam
lgtm
8 years, 5 months ago (2012-07-19 16:34:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10798010/1
8 years, 5 months ago (2012-07-19 16:40:39 UTC) #9
commit-bot: I haz the power
Failed to apply patch for content/content_jni.gypi: While running patch -p1 --forward --force; patching file content/content_jni.gypi ...
8 years, 5 months ago (2012-07-19 16:40:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10798010/9004
8 years, 5 months ago (2012-07-19 18:19:13 UTC) #11
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 20:02:58 UTC) #12
Change committed as 147515

Powered by Google App Engine
This is Rietveld 408576698