Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10798009: Android: fix step name for test runners. (Closed)

Created:
8 years, 5 months ago by bulach
Modified:
8 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: fix step name for test runners. Following http://codereview.chromium.org/10777017/, the step name contained the fully qualified path, it needs to be just the basename. BUG= TEST=run tests, note the step name. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147238

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/run_tests.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
bulach
8 years, 5 months ago (2012-07-18 12:21:03 UTC) #1
bulach
8 years, 5 months ago (2012-07-18 12:26:54 UTC) #2
Sami
LGTM. I guess this will fix the broken test step links at, e.g., http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Linux%20Android/builds/11136?
8 years, 5 months ago (2012-07-18 12:45:50 UTC) #3
bulach
yes, this patch should fix the links.. :) thanks! CQ'ing..
8 years, 5 months ago (2012-07-18 13:06:24 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-18 13:06:43 UTC) #5
bulach
+satish, need a full committer..
8 years, 5 months ago (2012-07-18 13:08:45 UTC) #6
Satish
lgtm
8 years, 5 months ago (2012-07-18 13:11:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/10798009/1
8 years, 5 months ago (2012-07-18 13:25:08 UTC) #8
commit-bot: I haz the power
8 years, 5 months ago (2012-07-18 14:59:11 UTC) #9
Change committed as 147238

Powered by Google App Engine
This is Rietveld 408576698