Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2925)

Issue 10798008: GDB: set correct data model for x86_64-nacl (Closed)

Created:
7 years, 2 months ago by eaeltsin
Modified:
7 years, 2 months ago
Reviewers:
halyavin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

GDB: set correct data model for x86_64-nacl This is required for reading typed values from target memory, in particular, to read correct pointer values. The change is risky. It confuses a lot of code that uses pointer size to distinguish from x86_64 and i386. Luckily, this code is mostly about native debugging and syscalls, so it is not used for NaCl. Anyway, the way to check for x86_64 by pointer size is lame, as it mixes architecture properties and data model. We plan to clean this up using some better check. The change is hacky, as it fixes types of registers values directly. This should be done in xml descriptions instead. However, this requires much more work, and this requires introducing NaCl-specific xml files. BUG= TEST= Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=8c22b25

Patch Set 1 #

Patch Set 2 : extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M gdb/features/i386/amd64-linux.c View 2 chunks +3 lines, -3 lines 0 comments Download
M gdb/nacl-tdep.c View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eaeltsin
7 years, 2 months ago (2012-07-18 11:49:05 UTC) #1
halyavin
7 years, 2 months ago (2012-07-18 11:54:25 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698