CPM: API changes for API/UI integration.

CPM: API changes for API/UI integration.

BUG=130212
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148407

[Matt Tytel, 2012-07-21 00:35:42]

Just some UI integration code/tweaking.

[koz (OOO until 15th September), 2012-07-23 06:58:18]

https://chromiumcodereview.appspot.com/10797056/diff/4001/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10797056/diff/4001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:23: double
UTCTimeToJsTime(const base::Time& utc_time) {
What's the difference between using this function and .ToJsTime()? Perhaps an
explanatory comment is in order?

[Matt Tytel, 2012-07-23 22:41:38]

https://chromiumcodereview.appspot.com/10797056/diff/4001/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10797056/diff/4001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:23: double
UTCTimeToJsTime(const base::Time& utc_time) {
Ah forgot to specify the locality of the JsTime. Wrote a commented and renamed
these.
Done.

[Evan Stade, 2012-07-23 23:09:50]

http://codereview.chromium.org/10797056/diff/7001/chrome/browser/performance_...
File chrome/browser/performance_monitor/performance_monitor.cc (left):

http://codereview.chromium.org/10797056/diff/7001/chrome/browser/performance_...
chrome/browser/performance_monitor/performance_monitor.cc:55: FROM_HERE,
the FROM_HERE part should remain here or it loses some of its usefulness.

http://codereview.chromium.org/10797056/diff/7001/chrome/browser/ui/webui/per...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

http://codereview.chromium.org/10797056/diff/7001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:28: return
base::Time::FromUTCExploded(exploded).ToJsTime();
piping LocalExplode to FromUTCExploded strikes me as wrong. You should get
someone very familiar with Time to review this.

http://codereview.chromium.org/10797056/diff/7001/chrome/browser/ui/webui/per...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:103: }
\n

[Matt Tytel, 2012-07-24 20:44:16]

Ah. Just removed the time conversions and doing it on the UI side instead.

https://chromiumcodereview.appspot.com/10797056/diff/7001/chrome/browser/perf...
File chrome/browser/performance_monitor/performance_monitor.cc (left):

https://chromiumcodereview.appspot.com/10797056/diff/7001/chrome/browser/perf...
chrome/browser/performance_monitor/performance_monitor.cc:55: FROM_HERE,
On 2012/07/23 23:09:50, Evan Stade wrote:
> the FROM_HERE part should remain here or it loses some of its usefulness.

Done.

https://chromiumcodereview.appspot.com/10797056/diff/7001/chrome/browser/ui/w...
File chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc (right):

https://chromiumcodereview.appspot.com/10797056/diff/7001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:28: return
base::Time::FromUTCExploded(exploded).ToJsTime();
Yea, I talked to Brettw about this.
We decided just to do this on the UI side.
Done.

https://chromiumcodereview.appspot.com/10797056/diff/7001/chrome/browser/ui/w...
chrome/browser/ui/webui/performance_monitor/web_ui_handler.cc:103: }
On 2012/07/23 23:09:50, Evan Stade wrote:
> \n

Done.

[Evan Stade, 2012-07-24 21:36:03]

lgtm

[koz (OOO until 15th September), 2012-07-24 22:45:14]

lgtm

[commit-bot: I haz the power, 2012-07-25 19:03:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mtytel@chromium.org/10797056/13001

[commit-bot: I haz the power, 2012-07-25 20:58:49]

Change committed as 148407