Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10797053: Add support for differentiating the form factor for Android NTP. (Closed)

Created:
8 years, 5 months ago by Ted C
Modified:
8 years, 5 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org
Visibility:
Public.

Description

Add support for differentiating the form factor for Android NTP. All towards the goal of upstreaming our NTP version. BUG=138245 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148003

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc View 1 3 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Ted C
8 years, 5 months ago (2012-07-20 20:41:45 UTC) #1
Evan Stade
https://chromiumcodereview.appspot.com/10797053/diff/1/chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc File chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc (right): https://chromiumcodereview.appspot.com/10797053/diff/1/chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc#newcode81 chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:81: if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUi)) { ternary operator
8 years, 5 months ago (2012-07-20 21:21:36 UTC) #2
Ted C
https://chromiumcodereview.appspot.com/10797053/diff/1/chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc File chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc (right): https://chromiumcodereview.appspot.com/10797053/diff/1/chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc#newcode81 chrome/browser/ui/webui/ntp/ntp_resource_cache_android.cc:81: if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kTabletUi)) { On 2012/07/20 21:21:36, Evan Stade wrote: ...
8 years, 5 months ago (2012-07-20 21:27:25 UTC) #3
Evan Stade
ltgm
8 years, 5 months ago (2012-07-20 21:31:59 UTC) #4
Ted C
On 2012/07/20 21:31:59, Evan Stade wrote: > ltgm Hmm...it appears you switched the 't' and ...
8 years, 5 months ago (2012-07-23 17:00:53 UTC) #5
Evan Stade
sorry lgtm
8 years, 5 months ago (2012-07-23 21:54:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10797053/3001
8 years, 5 months ago (2012-07-23 22:06:44 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 00:33:14 UTC) #8 
Change committed as 148003

Powered by Google App Engine
This is Rietveld 408576698