Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 10797037: Stale user_buffer_ pointer in PPB_URLLoader_impl after disptaching a callback (Closed)

Created:
8 years, 5 months ago by Tom Sepez
Modified:
8 years, 5 months ago
Reviewers:
brettw
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Remove possibility of stale user_buffer_ member in PPB_URLLoader_Impl when FinishedLoading() is called. BUG=137778 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147914

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M webkit/plugins/ppapi/ppb_url_loader_impl.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
Brett, PTAL.
8 years, 5 months ago (2012-07-19 22:48:32 UTC) #1
Tom Sepez
Brett, please review. I've added some tracing that shows that there's always a stale user_buffer_ ...
8 years, 5 months ago (2012-07-20 18:45:52 UTC) #2
brettw
lgtm
8 years, 5 months ago (2012-07-23 18:00:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/10797037/4002
8 years, 5 months ago (2012-07-23 18:17:28 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 20:26:43 UTC) #5
Change committed as 147914

Powered by Google App Engine
This is Rietveld 408576698