Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: tests/language/comparison_test.dart

Issue 10797031: Add missing type finalization for function literals not assigned to a function (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/comparison_test.dart
===================================================================
--- tests/language/comparison_test.dart (revision 9780)
+++ tests/language/comparison_test.dart (working copy)
@@ -155,20 +155,19 @@
Expect.equals(true, Helper.GE(1, -1));
Expect.equals(true, Helper.GE(1, 0));
- // TODO(regis): Double literals are not yet canonicalized.
- // Expect.equals(true, Helper.STRICT_EQ(-1.0, -1.0));
- // Expect.equals(true, Helper.STRICT_EQ(0.0, 0.0));
- // Expect.equals(true, Helper.STRICT_EQ(1.0, 1.0));
- // Expect.equals(false, Helper.STRICT_EQ(-1.0, 0.0));
- // Expect.equals(false, Helper.STRICT_EQ(-1.0, 1.0));
- // Expect.equals(false, Helper.STRICT_EQ(0.0, 1.0));
+ Expect.equals(true, Helper.STRICT_EQ(-1.0, -1.0));
+ Expect.equals(true, Helper.STRICT_EQ(0.0, 0.0));
+ Expect.equals(true, Helper.STRICT_EQ(1.0, 1.0));
+ Expect.equals(false, Helper.STRICT_EQ(-1.0, 0.0));
+ Expect.equals(false, Helper.STRICT_EQ(-1.0, 1.0));
+ Expect.equals(false, Helper.STRICT_EQ(0.0, 1.0));
- // Expect.equals(false, Helper.STRICT_NE(-1.0, -1.0));
- // Expect.equals(false, Helper.STRICT_NE(0.0, 0.0));
- // Expect.equals(false, Helper.STRICT_NE(1.0, 1.0));
- // Expect.equals(true, Helper.STRICT_NE(-1.0, 0.0));
- // Expect.equals(true, Helper.STRICT_NE(-1.0, 1.0));
- // Expect.equals(true, Helper.STRICT_NE(0.0, 1.0));
+ Expect.equals(false, Helper.STRICT_NE(-1.0, -1.0));
+ Expect.equals(false, Helper.STRICT_NE(0.0, 0.0));
+ Expect.equals(false, Helper.STRICT_NE(1.0, 1.0));
+ Expect.equals(true, Helper.STRICT_NE(-1.0, 0.0));
+ Expect.equals(true, Helper.STRICT_NE(-1.0, 1.0));
+ Expect.equals(true, Helper.STRICT_NE(0.0, 1.0));
Expect.equals(true, Helper.EQ(-1.0, -1.0));
Expect.equals(true, Helper.EQ(0.0, 0.0));
« no previous file with comments | « runtime/vm/parser.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698