Issue 10797027: Revert 147413 - gdrive: Get JSON feeds parsing off the UI thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10797027: Revert 147413 - gdrive: Get JSON feeds parsing off the UI thread. (Closed)

Created:
8 years, 5 months ago by jochen (gone - plz use gerrit)

Modified:
8 years, 5 months ago

Reviewers:
yoshiki

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 147413 - gdrive: Get JSON feeds parsing off the UI thread. BUG=128378 TEST=GDataOperationsTest.GetDataOperationParseJson passes. Review URL: https://chromiumcodereview.appspot.com/10808027 TBR=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147422

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -282 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_operations.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_operations.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
D	chrome/browser/chromeos/gdata/gdata_operations_unittest.cc	View	1 chunk	+0 lines, -189 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/operations_base.h	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/operations_base.cc	View	3 chunks	+29 lines, -75 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

8 years, 5 months ago (2012-07-19 10:50:04 UTC) #2

this broke browser_tests on linux:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20C...

Expand Messages | Collapse Messages