Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: vm/store_buffer.cc

Issue 10797021: - Start using the collected store buffer entries to find (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/store_buffer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/store_buffer.cc
===================================================================
--- vm/store_buffer.cc (revision 9784)
+++ vm/store_buffer.cc (working copy)
@@ -44,24 +44,34 @@
DedupSet* current = dedup_sets_;
dedup_sets_ = NULL;
while (current != NULL) {
- DedupSet* next = current->next_;
+ DedupSet* next = current->next();
delete current;
current = next;
}
}
+void StoreBuffer::Reset() {
+ DedupSet* current = DedupSets();
+ while (current != NULL) {
+ DedupSet* next = current->next();
+ delete current;
+ current = next;
+ }
+}
+
+
void StoreBuffer::AddPointer(uword address) {
ASSERT(dedup_sets_ != NULL);
- if (!dedup_sets_->set_->Add(address)) {
- // TODO(iposva): Limit growth of deduplication sets until the rest of the
- // mechanism is hooked up.
- delete dedup_sets_;
- dedup_sets_ = NULL;
-
- DedupSet* fresh_element = new DedupSet();
- fresh_element->next_ = dedup_sets_;
- dedup_sets_ = fresh_element;
+ if (!dedup_sets_->set()->Add(address)) {
+ // Add a new DedupSet. Schedule an interrupt if we have run over the max
+ // number of DedupSets.
+ dedup_sets_ = new DedupSet(dedup_sets_);
+ count_++;
+ // TODO(iposva): Fix magic number.
+ if (count_ > 100) {
+ Isolate::Current()->ScheduleInterrupts(Isolate::kStoreBufferInterrupt);
+ }
}
}
« no previous file with comments | « vm/store_buffer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698