Re-enabling checkdeps for most of ppapi + nacl.

Re-enabling checkdeps for most of ppapi + nacl.

Many of the includes / dependencies in ppapi + nacl are badly specified.
This turns on checkdeps for most stuff and makes extra stuff explicit.

BUG=http://code.google.com/p/chromium/issues/detail?id=93520
TEST=checkdeps passes
R=brettw@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148699

[brettw, 2012-07-18 22:19:57]

lgtm

[commit-bot: I haz the power, 2012-07-18 22:21:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10797018/1

[commit-bot: I haz the power, 2012-07-18 23:11:43]

Try job failure for 10797018-1 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-18 23:26:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10797018/7003

[commit-bot: I haz the power, 2012-07-19 00:19:06]

Try job failure for 10797018-7003 (retry) on linux_rel for step "check_deps".
It's a second try, previously, step "check_deps" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[bradn, 2012-07-19 00:33:51]

Ah, checkdeps + git no good.
Needs work...



On Wed, Jul 18, 2012 at 5:19 PM, <commit-bot@chromium.org> wrote:

> Try job failure for 10797018-7003 (retry) on linux_rel for step
> "check_deps".
>
> It's a second try, previously, step "check_deps" failed.
> http://build.chromium.org/p/**tryserver.chromium/**
>
buildstatus?builder=linux_rel&**number=40400<http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=40400>
>
>
>
https://chromiumcodereview.**appspot.com/10797018/<https://chromiumcodereview...
>

[bradn, 2012-07-25 21:09:09]

PTAL

[brettw, 2012-07-25 21:17:37]

http://codereview.chromium.org/10797018/diff/15001/base/DEPS
File base/DEPS (left):

http://codereview.chromium.org/10797018/diff/15001/base/DEPS#oldcode3
base/DEPS:3: "+native_client",
This change:
http://codereview.chromium.org/10795083/
seems to rely on this line being here. Is that change depending on the IRT
correct? If so, can we make this line be more specific?

http://codereview.chromium.org/10797018/diff/15001/ppapi/native_client/tests/...
File ppapi/native_client/tests/earth/DEPS (right):

http://codereview.chromium.org/10797018/diff/15001/ppapi/native_client/tests/...
ppapi/native_client/tests/earth/DEPS:4: "+native_client/common",  # This one
isn't even REAL!
This comment is actually more confusing than no comment. Can you elaborate?

[bradn, 2012-07-25 21:35:57]

PTAL

http://codereview.chromium.org/10797018/diff/15001/base/DEPS
File base/DEPS (left):

http://codereview.chromium.org/10797018/diff/15001/base/DEPS#oldcode3
base/DEPS:3: "+native_client",
On 2012/07/25 21:17:38, brettw wrote:
> This change:
> http://codereview.chromium.org/10795083/
> seems to rely on this line being here. Is that change depending on the IRT
> correct? If so, can we make this line be more specific?

So there's an outstanding issue of sorts with irt.h not being in the nacl sdk.
However, its not sensible to have it in the toolchain, as it depends on what you
built into chrome.
Within chrome including it directly makes sense, so I think sergeyu's change is
ok. I had assumed one of use would land first and we'd merge, and in the current
state nothing there is used.
Adding what he's planning to have.

http://codereview.chromium.org/10797018/diff/15001/ppapi/native_client/tests/...
File ppapi/native_client/tests/earth/DEPS (right):

http://codereview.chromium.org/10797018/diff/15001/ppapi/native_client/tests/...
ppapi/native_client/tests/earth/DEPS:4: "+native_client/common",  # This one
isn't even REAL!
On 2012/07/25 21:17:38, brettw wrote:
> This comment is actually more confusing than no comment. Can you elaborate?

Done.

[bradn, 2012-07-26 19:37:29]

PIng?

[Brad Chen (chromium), 2012-07-26 19:57:20]

LGTM

[commit-bot: I haz the power, 2012-07-26 19:57:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10797018/16011

[commit-bot: I haz the power, 2012-07-26 23:09:58]

Try job failure for 10797018-16011 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-07-26 23:43:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10797018/16011

[commit-bot: I haz the power, 2012-07-26 23:43:43]

Failed to apply patch for base/DEPS:
While running patch -p1 --forward --force;
patching file base/DEPS
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file base/DEPS.rej

[commit-bot: I haz the power, 2012-07-27 00:30:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bradnelson@google.com/10797018/29002

[commit-bot: I haz the power, 2012-07-27 02:11:17]

Change committed as 148699