Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 10797012: Fix memory leak in TraceSubscriberStdioImpl. (Closed)

Created:
8 years, 5 months ago by Iain Merrick
Modified:
8 years, 5 months ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, pam+watch_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Fix memory leak in TraceSubscriberStdioImpl. This class uses TraceBuffer internally, via a callback object. The callback references the TraceSubscriberStdioImpl so there was a reference cycle. Fixed by explicitly clearing the callback. BUG=115411 TEST=TraceSubscriberStdioTest under Valgrind Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -18 lines) Patch
M content/browser/trace_subscriber_stdio.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Iain Merrick
8 years, 5 months ago (2012-07-18 17:35:51 UTC) #1
Reid Kleckner (google)
LGTM
8 years, 5 months ago (2012-07-18 17:46:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10797012/1
8 years, 5 months ago (2012-07-19 12:36:41 UTC) #3
commit-bot: I haz the power
Presubmit check for 10797012-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-19 12:36:43 UTC) #4
Iain Merrick
Adding sky for OWNERS review.
8 years, 5 months ago (2012-07-19 13:49:17 UTC) #5
sky
LGTM
8 years, 5 months ago (2012-07-19 16:33:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/husky@chromium.org/10797012/1
8 years, 5 months ago (2012-07-19 16:42:10 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 18:02:07 UTC) #8
Change committed as 147482

Powered by Google App Engine
This is Rietveld 408576698