Issue 10797008: Refine object stats for FixedArrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10797008: Refine object stats for FixedArrays. (Closed)

Created:
8 years, 5 months ago by danno

Modified:
8 years, 5 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refine object stats for FixedArrays. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=12165

Patch Set 1 #

Patch Set 2 : Fix whitespace problems #

Total comments: 2

Patch Set 3 : Remove stray change #

Patch Set 4 : Remove stray change #

Patch Set 5 : Review feedback #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+196 lines, -10 lines)			Patch
M	src/extensions/statistics-extension.cc	View	1 2 3 4	2 chunks	+11 lines, -1 line	0 comments	Download
M	src/heap.h	View	1 2 3 4	2 chunks	+8 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 2 3 4	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/mark-compact.cc	View	1 2 3 4	2 chunks	+118 lines, -8 lines	0 comments	Download
M	src/objects.h	View	1 2 3 4	1 chunk	+19 lines, -0 lines	0 comments	Download
M	src/v8-counters.h	View		3 chunks	+18 lines, -0 lines	0 comments	Download
M	src/v8-counters.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

8 years, 5 months ago (2012-07-18 14:23:02 UTC) #2

LGTM with nits.

Also, can I suggest adding FIXED_ARRAY_SUB_INSTANCE_TYPE_LIST to
statistics-extension.cc to expose it using getV8Statistics()?

https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc
File src/mark-compact.cc (right):

https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc...
src/mark-compact.cc:947: static void
ObjectStatsVisitCore(StaticVisitorBase::VisitorId id,
We sometimes call this sort of stuff *Base. Maybe better than *Core?

https://chromiumcodereview.appspot.com/10797008/diff/3001/src/mark-compact.cc...
src/mark-compact.cc:1552: FAST_PROPERTIES_SUB_TYPE);
This looks exactly the same as the case above. Since JSArray is a subclass of
JSObject, why the specialization? The accessors to elements and properties are
the same ones anyways.

Expand Messages | Collapse Messages