Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 10797003: Change variable name to avoid scoping issues. (Closed)

Created:
8 years, 5 months ago by Cris Neckar
Modified:
8 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Change variable name to avoid scoping issues. Add an error condition to avoid entering a drag when a tab is being closed. BUG=137541 TEST=N/A Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147513

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/ui/gtk/tabs/tab_gtk.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Cris Neckar
8 years, 5 months ago (2012-07-18 00:50:19 UTC) #1
sky
http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode1282 chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:1282: TabGtk* selected_tab; selected_tab is only needed in the loop, ...
8 years, 5 months ago (2012-07-18 04:09:11 UTC) #2
Cris Neckar
On 2012/07/18 04:09:11, sky wrote: > http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc > File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): > > http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode1282 > ...
8 years, 5 months ago (2012-07-18 06:46:39 UTC) #3
Cris Neckar
http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): http://codereview.chromium.org/10797003/diff/6001/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode1282 chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:1282: TabGtk* selected_tab; On 2012/07/18 04:09:11, sky wrote: > selected_tab ...
8 years, 5 months ago (2012-07-18 19:35:14 UTC) #4
sky
http://codereview.chromium.org/10797003/diff/6002/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): http://codereview.chromium.org/10797003/diff/6002/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode1285 chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc:1285: GetTabAt(model()->selection_model().selected_indices()[i]); In looking at this again, this should be ...
8 years, 5 months ago (2012-07-18 21:12:04 UTC) #5
Cris Neckar
On 2012/07/18 21:12:04, sky wrote: > http://codereview.chromium.org/10797003/diff/6002/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc > File chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc (right): > > http://codereview.chromium.org/10797003/diff/6002/chrome/browser/ui/gtk/tabs/tab_strip_gtk.cc#newcode1285 > ...
8 years, 5 months ago (2012-07-18 22:14:21 UTC) #6
sky
LGTM http://codereview.chromium.org/10797003/diff/9003/chrome/browser/ui/gtk/tabs/tab_gtk.cc File chrome/browser/ui/gtk/tabs/tab_gtk.cc (right): http://codereview.chromium.org/10797003/diff/9003/chrome/browser/ui/gtk/tabs/tab_gtk.cc#newcode329 chrome/browser/ui/gtk/tabs/tab_gtk.cc:329: // If the tab is not selected don't ...
8 years, 5 months ago (2012-07-18 22:26:46 UTC) #7
Cris Neckar
http://codereview.chromium.org/10797003/diff/9003/chrome/browser/ui/gtk/tabs/tab_gtk.cc File chrome/browser/ui/gtk/tabs/tab_gtk.cc (right): http://codereview.chromium.org/10797003/diff/9003/chrome/browser/ui/gtk/tabs/tab_gtk.cc#newcode329 chrome/browser/ui/gtk/tabs/tab_gtk.cc:329: // If the tab is not selected don't start ...
8 years, 5 months ago (2012-07-19 18:18:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cdn@chromium.org/10797003/7002
8 years, 5 months ago (2012-07-19 18:19:03 UTC) #9
commit-bot: I haz the power
8 years, 5 months ago (2012-07-19 19:52:17 UTC) #10
Change committed as 147513

Powered by Google App Engine
This is Rietveld 408576698