Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/resources/shared/js/util.js

Issue 10796115: Enabled Selection (ctrl-A) on login password (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Generalized solution Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/util.js
diff --git a/chrome/browser/resources/shared/js/util.js b/chrome/browser/resources/shared/js/util.js
index c77fc3434d9707811ceb8520443361bfc1e7c5a9..5537a6de6dd787d7616e53013a4307638ffbe6a1 100644
--- a/chrome/browser/resources/shared/js/util.js
+++ b/chrome/browser/resources/shared/js/util.js
@@ -107,18 +107,24 @@ function swapDomNodes(a, b) {
}
/**
- * Disables text selection and dragging.
+ * Disables text selection and dragging, with optional whitelist callbacks.
+ * @param {function(Event):boolean=} opt_allowSelectStart If this function is
+ * defined and returns true, will allow the SelectStart event to be processed
Dan Beam 2012/07/25 01:07:49 nit: you need a subject in this sentence and need
+ * @param {function(Event):boolean=} opt_allowDragStart If this funcion is
+ * defined and returns true, will allow the DragStart event to be processed
*/
-function disableTextSelectAndDrag() {
+function disableTextSelectAndDrag(opt_allowSelectStart, opt_allowDragStart) {
// Disable text selection.
document.onselectstart = function(e) {
- e.preventDefault();
- }
+ if (!(opt_allowSelectStart && opt_allowSelectStart.call(this, e)))
+ e.preventDefault();
+ };
// Disable dragging.
document.ondragstart = function(e) {
- e.preventDefault();
- }
+ if (!(opt_allowDragStart && opt_allowDragStart.call(this, e)))
+ e.preventDefault();
+ };
}
/**

Powered by Google App Engine
This is Rietveld 408576698