Issue 10796111: touch: Fix a crash when touching a date-picker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10796111: touch: Fix a crash when touching a date-picker. (Closed)

Created:
8 years, 5 months ago by sadrul

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su, kevers

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

touch: Fix a crash when touching a date-picker. The date-picker popup does not have a RenderViewHost associated with it, so trying to use the RenderWidgetHost as a RenderViewHost ends up causing the crash. BUG=138741 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=148202

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	content/browser/renderer_host/render_widget_host_view_aura.cc	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages