Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Unified Diff: vm/intermediate_language.cc

Issue 10796108: Add a backward instruction iterator and use it in the liveness analysis. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/intermediate_language.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/intermediate_language.cc
===================================================================
--- vm/intermediate_language.cc (revision 9874)
+++ vm/intermediate_language.cc (working copy)
@@ -81,19 +81,13 @@
ASSERT(!current_->IsReturn());
ASSERT(!current_->IsReThrow());
ASSERT(current_->previous() != NULL);
+ ASSERT(current_ != block_entry_->last_instruction());
Instruction* prev = current_->previous();
Instruction* next = current_->next();
- prev->set_next(next);
ASSERT(next != NULL);
- if (current_ != block_entry_->last_instruction()) {
- ASSERT(!next->IsBlockEntry());
- next->set_previous(prev);
- } else {
- ASSERT(current_->IsBind());
- // Removing the last instruction of a block.
- // Update last_instruction of the current basic block.
- block_entry_->set_last_instruction(prev);
- }
+ ASSERT(!next->IsBlockEntry());
+ prev->set_next(next);
+ next->set_previous(prev);
// Reset successor and previous instruction to indicate
// that the instruction is removed from the graph.
current_->set_previous(NULL);
« no previous file with comments | « vm/intermediate_language.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698