Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 10796106: aura: Rename OnWindowVisisbilityChanged() to OnWindowTargetVisibilityChanged(). (Closed)

Created:
8 years, 5 months ago by tfarina
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

aura: Rename OnWindowVisisbilityChanged() to OnWindowTargetVisibilityChanged(). Note: This was a TODO for sky@. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148952

Patch Set 1 : #

Total comments: 2

Patch Set 2 : fix doc comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_delegate.h View 1 1 chunk +4 lines, -5 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
8 years, 5 months ago (2012-07-24 15:01:15 UTC) #1
sky
LGTM http://codereview.chromium.org/10796106/diff/13/ui/aura/window_delegate.h File ui/aura/window_delegate.h (right): http://codereview.chromium.org/10796106/diff/13/ui/aura/window_delegate.h#newcode87 ui/aura/window_delegate.h:87: // Called when the visibility of a Window ...
8 years, 5 months ago (2012-07-24 16:29:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/10796106/13002
8 years, 4 months ago (2012-07-30 11:34:02 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-07-30 14:38:52 UTC) #4
Change committed as 148952

Powered by Google App Engine
This is Rietveld 408576698