runtime/vm/stub_code_ia32.cc - Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

===================================================================

--- runtime/vm/stub_code_ia32.cc (revision 9834)

+++ runtime/vm/stub_code_ia32.cc (working copy)

@@ -1613,7 +1613,7 @@

__ cmpl(EAX, EDI); // Class id match?

__ j(EQUAL, &found, Assembler::kNearJump);

__ addl(EBX, Immediate(kWordSize * 2)); // Next element (class + target).

- __ cmpl(EDI, raw_null); // Done?

+ __ cmpl(EDI, Immediate(Smi::RawValue(kIllegalObjectKind))); // Done?

__ j(NOT_EQUAL, &loop, Assembler::kNearJump);

} else if (num_args == 2) {

// EDI: class to check.

@@ -1640,7 +1640,7 @@

__ Bind(&no_match);

// Each test entry has (1 + num_args) array elements.

__ addl(EBX, Immediate(kWordSize * (1 + num_args))); // Next element.

- __ cmpl(EDI, raw_null); // Done?

+ __ cmpl(EDI, Immediate(Smi::RawValue(kIllegalObjectKind))); // Done?

__ j(NOT_EQUAL, &loop, Assembler::kNearJump);

}

« no previous file with comments | « runtime/vm/raw_object.h ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »