Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 10796103: Use kIllegalObjectKind instead of NULL object to terminate ICData array (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_ia32.cc
===================================================================
--- runtime/vm/stub_code_ia32.cc (revision 9829)
+++ runtime/vm/stub_code_ia32.cc (working copy)
@@ -1613,7 +1613,7 @@
__ cmpl(EAX, EDI); // Class id match?
__ j(EQUAL, &found, Assembler::kNearJump);
__ addl(EBX, Immediate(kWordSize * 2)); // Next element (class + target).
- __ cmpl(EDI, raw_null); // Done?
+ __ cmpl(EDI, Immediate(Smi::RawValue(kIllegalObjectKind))); // Done?
__ j(NOT_EQUAL, &loop, Assembler::kNearJump);
} else if (num_args == 2) {
// EDI: class to check.
@@ -1640,7 +1640,7 @@
__ Bind(&no_match);
// Each test entry has (1 + num_args) array elements.
__ addl(EBX, Immediate(kWordSize * (1 + num_args))); // Next element.
- __ cmpl(EDI, raw_null); // Done?
+ __ cmpl(EDI, Immediate(Smi::RawValue(kIllegalObjectKind))); // Done?
__ j(NOT_EQUAL, &loop, Assembler::kNearJump);
}
« runtime/vm/object.cc ('K') | « runtime/vm/raw_object.h ('k') | runtime/vm/stub_code_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698