Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 10796101: Conditionally add the OpenGL ES 2.0 conformance tests to all.gyp (Closed)

Created:
8 years, 5 months ago by greggman
Modified:
8 years, 5 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews
Visibility:
Public.

Description

Conditionally add the OpenGL ES 2.0 conformance tests to all.gyp This is a step to getting the OpenGL ES 2.0 conformance tests running on the gpu bots. Actually running them will be another CL or 2. TEST=they build BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148023

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M build/all.gyp View 1 2 chunks +14 lines, -0 lines 0 comments Download
M build/common.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey Mo, PTAL
8 years, 5 months ago (2012-07-23 21:13:45 UTC) #1
Zhenyao Mo
https://chromiumcodereview.appspot.com/10796101/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/10796101/diff/1/build/all.gyp#newcode315 build/all.gyp:315: }], # internal_gles2_conform Just want to make sure: you ...
8 years, 5 months ago (2012-07-23 21:15:46 UTC) #2
greggman
https://chromiumcodereview.appspot.com/10796101/diff/1/build/all.gyp File build/all.gyp (right): https://chromiumcodereview.appspot.com/10796101/diff/1/build/all.gyp#newcode315 build/all.gyp:315: }], # internal_gles2_conform On 2012/07/23 21:15:46, Zhenyao Mo wrote: ...
8 years, 5 months ago (2012-07-23 22:22:19 UTC) #3
Zhenyao Mo
LGTM
8 years, 5 months ago (2012-07-23 22:25:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10796101/4002
8 years, 5 months ago (2012-07-23 23:49:08 UTC) #5
commit-bot: I haz the power
8 years, 5 months ago (2012-07-24 01:27:18 UTC) #6
Change committed as 148023

Powered by Google App Engine
This is Rietveld 408576698