Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 10796092: More changes to fix pnacl nmf issue when rolling DEPS. (Closed)

Created:
8 years, 5 months ago by nfullagar
Modified:
8 years, 5 months ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews
Visibility:
Public.

Description

More changes to fix PNaCl NMF issue when rolling DEPS In the NaCl standalone build, this invocation on the PNaCl bots produced the following error: ./scons --verbose bitcode=1 skip_trusted_tests=1 -j6 do_not_run_tests=1 --mode=opt-host,nacl platform=x86-64 ... scons: *** [scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio.nmf] Source `scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio_x86-64.nexe' not found, needed by target `scons-out/nacl-x86-64-pnacl-pexe-clang/staging/ppapi_ppb_audio.nmf'. TEST=the scons invocation above BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147905

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -10 lines) Patch
M ppapi/native_client/tests/ppapi_browser/ppb_audio/nacl.scons View 1 2 chunks +1 line, -3 lines 0 comments Download
D ppapi/native_client/tests/ppapi_browser/ppb_audio/ppapi_ppb_audio.nmf View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nfullagar
8 years, 5 months ago (2012-07-23 18:16:47 UTC) #1
Mark Seaborn
LGTM. I've updated your commit message to describe the problem you're fixing. https://chromiumcodereview.appspot.com/10796092/diff/1/ppapi/native_client/tests/ppapi_browser/ppb_audio/nacl.scons File ppapi/native_client/tests/ppapi_browser/ppb_audio/nacl.scons ...
8 years, 5 months ago (2012-07-23 18:23:27 UTC) #2
nfullagar
8 years, 5 months ago (2012-07-23 19:57:15 UTC) #3
thx, line removed.
Committed revision 147905.


On 2012/07/23 18:23:27, Mark Seaborn wrote:
> LGTM.  I've updated your commit message to describe the problem you're fixing.
> 
>
https://chromiumcodereview.appspot.com/10796092/diff/1/ppapi/native_client/te...
> File ppapi/native_client/tests/ppapi_browser/ppb_audio/nacl.scons (right):
> 
>
https://chromiumcodereview.appspot.com/10796092/diff/1/ppapi/native_client/te...
> ppapi/native_client/tests/ppapi_browser/ppb_audio/nacl.scons:11:
> env.Replace(TEST_DIR='${SOURCE_ROOT}/ppapi/native_client/tests/ppapi_browser/'
> You can remove this since it's no longer used now

Powered by Google App Engine
This is Rietveld 408576698