Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 10796079: Added unique function names (IOTHreadRun, DBTHreadRun, etc) (Closed)

Created:
8 years, 5 months ago by ramant (doing other things)
Modified:
8 years, 5 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, eroman
Visibility:
Public.

Description

Added unique function names (IOThreadRun, DBThreadRun, etc) which make it possible to tell the thread name in crash dumps from the call stack. Added a volatile automatic variable to avoid global optimizers optimizing the function. This change would help us to triage ThreadWatcher crashes for IO thread. It would also help in debugging crashes. R=sky, jar Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147949

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -0 lines) Patch
M content/browser/browser_thread_impl.h View 1 2 chunks +12 lines, -0 lines 0 comments Download
M content/browser/browser_thread_impl.cc View 1 2 3 1 chunk +85 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
Hi sky and jar, Implemented changes similar to what eroman had implemented in ThreadWatcher to ...
8 years, 5 months ago (2012-07-21 20:56:38 UTC) #1
jar (doing other things)
lgtm
8 years, 5 months ago (2012-07-21 23:19:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10796079/7003
8 years, 5 months ago (2012-07-22 00:34:36 UTC) #3
commit-bot: I haz the power
Presubmit check for 10796079-7003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-22 00:34:41 UTC) #4
sky
I added Eric to the review list. https://chromiumcodereview.appspot.com/10796079/diff/7003/content/browser/browser_thread_impl.cc File content/browser/browser_thread_impl.cc (right): https://chromiumcodereview.appspot.com/10796079/diff/7003/content/browser/browser_thread_impl.cc#newcode101 content/browser/browser_thread_impl.cc:101: #if defined(COMPILER_MSVC) ...
8 years, 5 months ago (2012-07-23 15:49:17 UTC) #5
ramant (doing other things)
Hi Eric, I had used what you had done in ThreadWatcher.cc (removed the COMPILER_MSVC ifdef). ...
8 years, 5 months ago (2012-07-23 17:33:04 UTC) #6
jar (doing other things)
The line numbers ensure that the secondary (link-time) optimizer won't "fold the identical functions" into ...
8 years, 5 months ago (2012-07-23 17:37:41 UTC) #7
eroman
For VC++ the MSVC_DISABLE_OPTIMIZE() is sufficient to thwart all optimizations. The use of __LINE__ is ...
8 years, 5 months ago (2012-07-23 17:59:02 UTC) #8
sky
LGTM
8 years, 5 months ago (2012-07-23 18:19:32 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10796079/3002
8 years, 5 months ago (2012-07-23 18:21:41 UTC) #10
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 19:58:03 UTC) #11
Try job failure for 10796079-3002 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698