Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 10796072: [Chromoting] Tidy up SkISize initialization. (Closed)

Created:
8 years, 5 months ago by simonmorris
Modified:
8 years, 5 months ago
Reviewers:
Wez, Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

[Chromoting] Tidy up SkISize initialization. The root cause of crbug.com/137878 was r103533, which replaced a class whose default constructor initialized objects fully, with a struct for which that isn't the case. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147933

Patch Set 1 #

Patch Set 2 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M remoting/host/video_frame_capturer_fake.cc View 1 chunk +2 lines, -1 line 0 comments Download
M remoting/host/video_frame_capturer_linux.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
simonmorris
ptal
8 years, 5 months ago (2012-07-20 23:18:23 UTC) #1
Wez
LGTM - nice detective work. :)
8 years, 5 months ago (2012-07-20 23:58:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10796072/1
8 years, 5 months ago (2012-07-21 00:43:06 UTC) #3
commit-bot: I haz the power
Try job failure for 10796072-1 (retry) on linux_clang for step "compile" (clobber build). It's a ...
8 years, 5 months ago (2012-07-21 01:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10796072/8002
8 years, 5 months ago (2012-07-23 16:30:11 UTC) #5
commit-bot: I haz the power
Try job failure for 10796072-8002 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 5 months ago (2012-07-23 17:32:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10796072/8002
8 years, 5 months ago (2012-07-23 18:38:01 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 20:40:04 UTC) #8
Change committed as 147933

Powered by Google App Engine
This is Rietveld 408576698