Issue 10796071: Enable new checkbox style by default (Linux/CrOS only)

Issue 10796071: Enable new checkbox style by default (Linux/CrOS only) (Closed)

Created:
8 years, 5 months ago by Rick Byers

Modified:
8 years, 5 months ago

Reviewers:
sky

CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable new checkbox style by default (Linux/CrOS only) Also stop supporting non-square widgets, no other browser seems to do this and it exposes bugs in web pages. BUG=125773 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147887

Patch Set 1 #

Patch Set 2 : Merge with trunk #

Total comments: 1

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -29 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/about_flags.cc	View	1	2 chunks	+7 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_utils.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/native_theme/native_theme_base.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/base/native_theme/native_theme_base.cc	View		3 chunks	+15 lines, -11 lines	1 comment	Download
M	ui/base/ui_base_switches.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ui/base/ui_base_switches.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Rick Byers

Hey Scott, can you review this update to the checkbox stuff you reviewed before?

8 years, 5 months ago (2012-07-20 23:16:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rbyers@chromium.org/10796071/9001

8 years, 5 months ago (2012-07-23 17:18:49 UTC) #3

Avi (use Gerrit)

8 years, 5 months ago (2012-07-23 19:29:07 UTC) #5

https://chromiumcodereview.appspot.com/10796071/diff/9001/ui/base/native_them...
File ui/base/native_theme/native_theme_base.cc (right):

https://chromiumcodereview.appspot.com/10796071/diff/9001/ui/base/native_them...
ui/base/native_theme/native_theme_base.cc:522: // Use the largest square
rectangle that fits inside the provided rectangle.
drive-by: s/square rectangle/square/

Expand Messages | Collapse Messages