Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: Source/WebCore/ChangeLog

Side-by-side diff isn't available for this file because of its large size.
Issue 10796066: Merge 122883 - vertical-align: middle causes overflow with subpixel layout (Closed) Base URL:
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: Source/WebCore/ChangeLog
--- Source/WebCore/ChangeLog (revision 123234)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,5 +1,25 @@
2012-07-17 Emil A Eklund <>
+ vertical-align: middle causes overflow with subpixel layout
+ Reviewed by Eric Seidel.
+ Using vertical-align: middle in combination with an overflow value other
+ than visible can cause the overflow height to be computed incorrectly.
+ Test: fast/sub-pixel/vertical-align-middle-overflow.html
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::verticalPositionForBox):
+ Round verticalPosition after calculation instead of flooring the result
+ of the xHeight calculation. By flooring it the resulting value is in
+ effect rounded up which can cause the height of the box to grow by one.
+ By rounding the resulting value thevertical position is more accurate and
+ the off by one error is avoided.
+2012-07-17 Emil A Eklund <>
Incorrect offset used for scrollWidth/Height calculation

Powered by Google App Engine
This is Rietveld 408576698