Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 10796062: Moving chrome_auth_private to c/b/extensions/api (Closed)

Created:
8 years, 5 months ago by vabr (Chromium)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, jstritar
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Moving chrome_auth_private to c/b/extensions/api BUG=101244 TEST=N/A, only moving code, no change in functionality Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -151 lines) Patch
A + chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_api.h View 2 chunks +6 lines, -3 lines 0 comments Download
A + chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_api.cc View 3 chunks +5 lines, -1 line 0 comments Download
A + chrome/browser/extensions/api/chrome_auth_private/chrome_auth_private_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D chrome/browser/extensions/extension_chrome_auth_private_api.h View 1 chunk +0 lines, -30 lines 0 comments Download
D chrome/browser/extensions/extension_chrome_auth_private_api.cc View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/extensions/extension_chrome_auth_private_apitest.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
vabr (Chromium)
Hi, Could you please review this moving of code? Thanks, Vaclav
8 years, 5 months ago (2012-07-20 17:05:27 UTC) #1
vabr (Chromium)
On 2012/07/20 17:05:27, vabr (Chromium) wrote: > Hi, > > Could you please review this ...
8 years, 5 months ago (2012-07-25 08:24:15 UTC) #2
vabr (Chromium)
Hi Mihai, Do you think you could review this? Originally I asked Jon, but it ...
8 years, 5 months ago (2012-07-26 08:41:27 UTC) #3
Mihai Parparita -not on Chrome
LGTM Sorry about the delay.
8 years, 5 months ago (2012-07-26 17:59:20 UTC) #4
vabr (Chromium)
On 2012/07/26 17:59:20, Mihai Parparita wrote: > LGTM > > Sorry about the delay. Thanks, ...
8 years, 5 months ago (2012-07-26 20:30:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10796062/1
8 years, 5 months ago (2012-07-26 20:30:50 UTC) #6
commit-bot: I haz the power
Presubmit check for 10796062-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-26 20:30:56 UTC) #7
darin (slow to review)
LGTM
8 years, 5 months ago (2012-07-26 20:38:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/10796062/1
8 years, 5 months ago (2012-07-26 20:52:03 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-07-26 23:37:30 UTC) #10
Change committed as 148652

Powered by Google App Engine
This is Rietveld 408576698