Issue 10796058: Cleaned up AST nodes a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10796058: Cleaned up AST nodes a bit. (Closed)

Created:
8 years, 5 months ago by Sven Panne

Modified:
8 years, 5 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleaned up AST nodes a bit. * Made AST IDs constant. Making this explicit helps understanding the code. * Removed a few dead functions. * Be honest by making node_type() pure virtual. All these changes have been checked to be performance-neutral. Committed: https://code.google.com/p/v8/source/detail?r=12153

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -52 lines)			Patch
	M	src/ast.h	View		26 chunks	+40 lines, -51 lines	0 comments	Download
	M	src/ast.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages