chrome/browser/resources/about_memory_linux.html - Issue 10796054: Adapt the linux about_memory page to better render on Android.

Unified Diff: chrome/browser/resources/about_memory_linux.html

Issue 10796054: Adapt the linux about_memory page to better render on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use grd syntax for specifying android. Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/about_memory_linux.html

diff --git a/chrome/browser/resources/about_memory_linux.html b/chrome/browser/resources/about_memory_linux.html

index 17b6e3aa73a2a2fb7f961cfeb8490a16751990e6..951db0753bf40415b60f3da936a93dadc053238c 100644

--- a/chrome/browser/resources/about_memory_linux.html

+++ b/chrome/browser/resources/about_memory_linux.html

@@ -10,6 +10,10 @@ about:memory template page

<style>

body {

font-family: Arial, Helvetica, sans-serif;

+<if expr="pp_ifdef('android')">

+ font-size: 22pt;

Evan Stade 2012/07/23 22:03:01 you should set the font-size on <body> like <body

Ted C 2012/07/23 22:18:00 I'm just overriding the values defined in about_me

Evan Stade 2012/07/23 22:44:27 it can be overridden by the page but usually we'd

Ted C 2012/07/24 20:51:50 The css file is shared across all platforms, so th

Evan Stade 2012/07/24 21:37:04 it's not your fault, but that is not a valid reaso

it's not your fault, but that is not a valid reason to have css in an html file. There is actually no valid reason to have css in an html file. Please don't add any more. Refactor it if you can.

on every platform the default for webui:// pages is your system default. For my linux desktop, that happens to be 'DejaVu sans'. This page disregards that because it predated SetFontAndTextDirection, and no one thought to update it.

because they were added before the appearance of webui was standardized. This page is obviously not really intended to be user-facing because the text is not even translated (although as far as I'm aware, this page is less for debugging and more for helping users analyze the browsers they have on their system, so it should probably be translated). The page as a whole has such an oddball UI that I wouldn't worry too much about messing with the appearance; it's obviously been neglected for many years.

+ min-width: 30em;

+</if>

}

div#header select {

font-family: Arial, Helvetica, sans-serif;

@@ -47,11 +51,20 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {

<div>

<p>

+<if expr="not pp_ifdef('android')">

Summary of memory used by currently active browsers.

For browsers which use multiple processes, memory reflects

aggregate memory used across all browser processes.<p>

For Chromium, processes used to to display diagnostics

information (such as this "about:memory") are excluded.

+</if>

+<if expr="pp_ifdef('android')">

+ Summary of memory used by Chromium. Since Chromium uses

Evan Stade 2012/07/23 22:03:01 why did you change the string? The difference seem

Ted C 2012/07/23 22:18:00 The main reason is that this was what we had in th

Evan Stade 2012/07/23 22:44:27 OK, now I understand the difference. Still, I thin

Ted C 2012/07/24 20:51:50 Done...but it's worth nothing that Chromium is use

+ multiple processes, memory reflects

+ aggregate memory used across all browser processes.<p>

+ For Chromium, processes used to display diagnostics

+ information (such as this "about:memory") are excluded.

+</if>

</p>

</div>

« no previous file with comments | « chrome/browser/defaults.cc ('k') | no next file » | no next file with comments »