Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6331)

Unified Diff: chrome/browser/resources/about_memory_linux.html

Issue 10796054: Adapt the linux about_memory page to better render on Android. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Using grd summary descriptions. Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/about_memory_linux.html
diff --git a/chrome/browser/resources/about_memory_linux.html b/chrome/browser/resources/about_memory_linux.html
index 17b6e3aa73a2a2fb7f961cfeb8490a16751990e6..61e31719d229ff5ec4f71566b7963f23f2027fe1 100644
--- a/chrome/browser/resources/about_memory_linux.html
+++ b/chrome/browser/resources/about_memory_linux.html
@@ -10,6 +10,10 @@ about:memory template page
<style>
body {
font-family: Arial, Helvetica, sans-serif;
+<if expr="pp_ifdef('android')">
+ font-size: 1.7em;
+ min-width: 30em;
+</if>
}
div#header select {
font-family: Arial, Helvetica, sans-serif;
@@ -46,13 +50,18 @@ table.list#memoryDetails tr.firstRow th:nth-child(2) {
Summary
<div class='help'>
<div>
- <p>
+<if expr="not pp_ifdef('android')">
+ <p>
Summary of memory used by currently active browsers.
Evan Stade 2012/07/24 21:37:04 I meant for you to pull both summaries out of here
Ted C 2012/07/24 23:54:47 Done.
For browsers which use multiple processes, memory reflects
aggregate memory used across all browser processes.<p>
For Chromium, processes used to to display diagnostics
information (such as this "about:memory") are excluded.
- </p>
+ </p>
+</if>
+<if expr="pp_ifdef('android')">
+ <p jsvalues=".innerHTML:summary_desc"></p>
Evan Stade 2012/07/24 21:37:04 usually we use i18n-values:
Ted C 2012/07/24 23:54:47 Done.
+</if>
</div>
</div>
</h2>

Powered by Google App Engine
This is Rietveld 408576698