Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 10796049: Move WebDialogWebContentsDelegate to ui/web_dialogs. (Closed)

Created:
8 years, 5 months ago by mazda
Modified:
8 years, 5 months ago
Reviewers:
Albert Bodenhamer, sky
CC:
chromium-reviews
Visibility:
Public.

Description

Move WebDialogWebContentsDelegate to ui/web_dialogs. Also move WebDialogWebContentsDelegate into ui namespace. BUG=124222, 125841 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -156 lines) Patch
M chrome/browser/printing/print_preview_tab_controller.cc View 3 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/web_dialog_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/web_dialog_view.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_contents_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/constrained_web_dialog_delegate_base.cc View 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/ui/webui/web_dialog_web_contents_delegate.h View 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/ui/webui/web_dialog_web_contents_delegate.cc View 1 chunk +0 lines, -59 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/web_dialogs/constrained_web_dialog_ui.h View 2 chunks +1 line, -1 line 0 comments Download
A + ui/web_dialogs/web_dialog_web_contents_delegate.h View 2 chunks +10 lines, -4 lines 0 comments Download
A + ui/web_dialogs/web_dialog_web_contents_delegate.cc View 3 chunks +5 lines, -1 line 0 comments Download
M ui/web_dialogs/web_dialogs.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mazda
Scott, Could you review this? This is a mostly mechanical change. Thanks,
8 years, 5 months ago (2012-07-19 23:28:15 UTC) #1
sky
LGTM
8 years, 5 months ago (2012-07-20 00:07:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10796049/1
8 years, 5 months ago (2012-07-20 00:09:13 UTC) #3
commit-bot: I haz the power
Presubmit check for 10796049-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 5 months ago (2012-07-20 00:09:30 UTC) #4
mazda
+abodenha, Could you do an OWNERS review for chrome/browser/printing again? Thanks,
8 years, 5 months ago (2012-07-20 00:11:59 UTC) #5
Albert Bodenhamer
lgtm
8 years, 5 months ago (2012-07-20 03:55:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10796049/1
8 years, 5 months ago (2012-07-20 04:11:34 UTC) #7
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 06:20:11 UTC) #8
Change committed as 147620

Powered by Google App Engine
This is Rietveld 408576698