base: Class member variables should be ended with trailing underscores.

base: Class member variables should be ended with trailing underscores.
    
Fix ScopedVector API to follow this style.
    
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Variable_Names#Variable_Names

BUG=136196
R=willchan@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148057

[tfarina, 2012-07-20 02:12:08]

Will, ping?

[tfarina, 2012-07-20 14:46:32]

+Brett for review.

Question: Brett, do you think this organization is better? If not, could you
suggest another organization that would make it easier to follow/read.

Thanks.

[willchan no longer on Chromium, 2012-07-20 14:54:30]

Sorry, still digging myself out of email debt. I honestly don't know if
there's an organization that's best. I'm lukewarm on this change, but don't
really care.

[tfarina, 2012-07-20 14:58:10]

On Fri, Jul 20, 2012 at 11:54 AM, William Chan (陈智昌)
<willchan@chromium.org> wrote:
> Sorry, still digging myself out of email debt. I honestly don't know if
> there's an organization that's best. I'm lukewarm on this change, but don't
> really care.
Yeah, I'm not too sure about it too. I just though in improving it a
bit. May be it isn't so worth though :)

But I like the new position of the functions.


-- 
Thiago

[brettw, 2012-07-20 20:44:19]

Renaming v -> v_ seems good, but the rest seems like unnecessary churn to me.

[tfarina, 2012-07-21 00:51:00]

On Friday, July 20, 2012, wrote:

> Renaming v -> v_ seems good, but the rest seems like unnecessary churn to
> me.
>
> OK OK, I'll do this change. This churn thing haunts me!! Everytime I'm not
really sure what to do ir what to improve, IT appears! Sigh!!


>
http://codereview.chromium.**org/10796028/<http://codereview.chromium.org/107...
>


-- 
Thiago

[tfarina, 2012-07-22 02:57:21]

I think this was the most stupid, non-brain patch I ever did :-(

Uhh, anyway, here it's for review.

Please, take another look.

[brettw, 2012-07-23 18:23:19]

There's still a bunch of reordering that makes it hard to see what changed here.

[willchan no longer on Chromium, 2012-07-23 18:34:05]

+1. Please just do the member variable rename.

[tfarina, 2012-07-24 04:06:18]

On 2012/07/23 18:34:05, willchan wrote:
> +1. Please just do the member variable rename.

No moves this time. PTAL!

I agree this is now much easier to review ;)

[willchan no longer on Chromium, 2012-07-24 04:43:43]

lgtm

[commit-bot: I haz the power, 2012-07-24 04:43:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/10796028/12003

[commit-bot: I haz the power, 2012-07-24 06:08:49]

Change committed as 148057