Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 10796004: Consolidate a few fields in RawFunction using bitfields. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/raw_object_snapshot.cc
===================================================================
--- runtime/vm/raw_object_snapshot.cc (revision 9727)
+++ runtime/vm/raw_object_snapshot.cc (working copy)
@@ -433,6 +433,7 @@
func.set_is_const(reader->Read<bool>());
func.set_is_optimizable(reader->Read<bool>());
func.set_is_native(reader->Read<bool>());
+ func.set_is_abstract(reader->Read<bool>());
// Set all the object fields.
// TODO(5411462): Need to assert No GC can happen here, even though
@@ -467,11 +468,12 @@
writer->WriteIntptrValue(ptr()->num_optional_parameters_);
writer->WriteIntptrValue(ptr()->usage_counter_);
writer->WriteIntptrValue(ptr()->deoptimization_counter_);
- writer->WriteIntptrValue(ptr()->kind_);
- writer->Write<bool>(ptr()->is_static_);
- writer->Write<bool>(ptr()->is_const_);
- writer->Write<bool>(ptr()->is_optimizable_);
- writer->Write<bool>(ptr()->is_native_);
+ writer->WriteIntptrValue(GetKind());
turnidge 2012/07/18 04:57:15 Or... I could just write out kind_tag_ directly as
+ writer->Write<bool>(IsStatic());
+ writer->Write<bool>(IsConst());
+ writer->Write<bool>(IsOptimizable());
+ writer->Write<bool>(IsNative());
+ writer->Write<bool>(IsAbstract());
// Write out all the object pointer fields.
SnapshotWriterVisitor visitor(writer);

Powered by Google App Engine
This is Rietveld 408576698