Consolidate a few fields in RawFunction using bitfields.

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 
 #include "vm/bigint_operations.h"
 #include "vm/class_finalizer.h"
 #include "vm/compiler.h"
 #include "vm/dart.h"
@@ skipping 2716 matching lines @@
         CURRENT_FUNC);
   }
 
 #if defined(DEBUG)
   if (!func.IsNull()) {
     // We only provide access to a subset of function kinds.
     RawFunction::Kind func_kind = func.kind();
     ASSERT(func_kind == RawFunction::kFunction ||
            func_kind == RawFunction::kGetterFunction ||
            func_kind == RawFunction::kSetterFunction ||
-           func_kind == RawFunction::kConstructor ||
-           func_kind == RawFunction::kAbstract);
+           func_kind == RawFunction::kConstructor);
   }
 #endif
   return Api::NewHandle(isolate, func.raw());
 }
 
 
 DART_EXPORT bool Dart_IsFunction(Dart_Handle handle) {
   return Api::ClassId(handle) == kFunction;
 }
 
@@ skipping 20 matching lines @@
                                                 bool* is_abstract) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   if (is_abstract == NULL) {
     RETURN_NULL_ERROR(is_abstract);
   }
   const Function& func = Api::UnwrapFunctionHandle(isolate, function);
   if (func.IsNull()) {
     RETURN_TYPE_ERROR(isolate, function, Function);
   }
-  *is_abstract = (func.kind() == RawFunction::kAbstract);
+  *is_abstract = func.is_abstract();
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_FunctionIsStatic(Dart_Handle function,
                                               bool* is_static) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   if (is_static == NULL) {
     RETURN_NULL_ERROR(is_static);
@@ skipping 27 matching lines @@
                                               bool* is_getter) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   if (is_getter == NULL) {
     RETURN_NULL_ERROR(is_getter);
   }
   const Function& func = Api::UnwrapFunctionHandle(isolate, function);
   if (func.IsNull()) {
     RETURN_TYPE_ERROR(isolate, function, Function);
   }
-  // TODO(turnidge): It would be nice if I could just use func.kind()
-  // to check for a getter function here, but unfortunately the only
-  // way to distinguish abstract getter functions is to use the name
-  // itself.  Consider adding a RawFunction::kAbstractGetter type.
-  const String& func_name = String::Handle(isolate, func.name());
-  *is_getter = Field::IsGetterName(func_name);
-
+  *is_getter = (func.kind() == RawFunction::kGetterFunction);
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_FunctionIsSetter(Dart_Handle function,
                                               bool* is_setter) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
   if (is_setter == NULL) {
     RETURN_NULL_ERROR(is_setter);
   }
   const Function& func = Api::UnwrapFunctionHandle(isolate, function);
   if (func.IsNull()) {
     RETURN_TYPE_ERROR(isolate, function, Function);
   }
-  // TODO(turnidge): It would be nice if I could just use func.kind()
-  // to check for a setter function here, but unfortunately the only
-  // way to distinguish abstract setter functions is to use the name
-  // itself.  Consider adding a RawFunction::kAbstractSetter type.
-  const String& func_name = String::Handle(isolate, func.name());
-  *is_setter = Field::IsSetterName(func_name);
-
+  *is_setter = (func.kind() == RawFunction::kSetterFunction);
   return Api::Success(isolate);
 }
 
 
 DART_EXPORT Dart_Handle Dart_FunctionParameterCounts(
     Dart_Handle function,
     int64_t* fixed_param_count,
     int64_t* opt_param_count) {
   Isolate* isolate = Isolate::Current();
   DARTSCOPE(isolate);
@@ skipping 1282 matching lines @@
     *buffer_size = 0;
   }
 }
 
 
 DART_EXPORT void Dart_InitFlowGraphPrinting(FileWriterFunction function) {
   Dart::set_flow_graph_writer(function);
 }
 
 }  // namespace dart