chrome/browser/download/download_browsertest.cc - Issue 10795090: Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_browsertest.cc

Issue 10795090: Move ExecuteJavaScript functions from ui_test_utils.h to browser_test_utils.h so they can be reused… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/debugger/devtools_sanity_browsertest.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_browsertest.cc

===================================================================

--- chrome/browser/download/download_browsertest.cc (revision 148111)

+++ chrome/browser/download/download_browsertest.cc (working copy)

@@ -60,6 +60,7 @@

#include "content/public/browser/web_contents.h"

#include "content/public/common/context_menu_params.h"

#include "content/public/common/page_transition_types.h"

+#include "content/public/test/browser_test_utils.h"

#include "content/public/test/test_file_error_injector.h"

#include "content/public/test/test_navigation_observer.h"

#include "content/test/net/url_request_mock_http_job.h"

@@ -1026,7 +1027,7 @@

NULL,

1);

bool download_assempted;

- ASSERT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

+ ASSERT_TRUE(content::ExecuteJavaScriptAndExtractBool(

chrome::GetActiveWebContents(browser())->GetRenderViewHost(),

L"",

L"window.domAutomationController.send(startDownload());",

@@ -1607,7 +1608,7 @@

WebContents* contents = chrome::GetActiveWebContents(browser());

ASSERT_TRUE(contents);

bool webui_responded = false;

- EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

+ EXPECT_TRUE(content::ExecuteJavaScriptAndExtractBool(

contents->GetRenderViewHost(),

L"",

L"window.domAutomationController.send(window.webui_responded_);",

@@ -1627,7 +1628,7 @@

WebContents* contents = chrome::GetActiveWebContents(browser());

ASSERT_TRUE(contents);

bool result = false;

- EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

+ EXPECT_TRUE(content::ExecuteJavaScriptAndExtractBool(

contents->GetRenderViewHost(),

L"",

L"window.onunload = function() { var do_nothing = 0; }; "