Issue 10795078: Fixes two bugs related to constrained windows:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10795078: Fixes two bugs related to constrained windows: (Closed)

Created:
8 years, 5 months ago by sky

Modified:
8 years, 5 months ago

Reviewers:
oshima, Ben Goodger (Google)

CC:
chromium-reviews, tfarina, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixes two bugs related to constrained windows: . Make them no bigger than the parent (otherwise you can't move/close them). . Fixes coordinate conversion bug. BUG=128105 TEST=covered by unit test R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148241

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -6 lines)			Patch
M	chrome/browser/ui/views/constrained_web_dialog_delegate_views.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	ui/views/widget/native_widget_aura_unittest.cc	View	2 chunks	+17 lines, -1 line	0 comments	Download
M	ui/views/window/client_view.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/window/client_view.cc	View	1 chunk	+7 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

sky

I added Oshima as he added ScreenPositionClient that is part of the issue here.

8 years, 5 months ago (2012-07-23 22:26:19 UTC) #2

oshima

lgtm Sorry, sounds like my test wasn't enough. Thank you for fix.

8 years, 5 months ago (2012-07-23 23:28:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/10795078/1

8 years, 5 months ago (2012-07-24 20:57:44 UTC) #5

Change committed as 148241