Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Unified Diff: remoting/client/plugin/pepper_audio_player.h

Issue 10795066: Support for both 44.1 kHz and 48 kHz on the client. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Small cleanup Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/client/plugin/pepper_audio_player.h
diff --git a/remoting/client/plugin/pepper_audio_player.h b/remoting/client/plugin/pepper_audio_player.h
index 925b0dcda7deba659eae63093b992d90fac3104e..ad7c53dc687be3cc1b9136e65eb414c9dc75b9ca 100644
--- a/remoting/client/plugin/pepper_audio_player.h
+++ b/remoting/client/plugin/pepper_audio_player.h
@@ -15,26 +15,24 @@
#include "ppapi/cpp/audio.h"
#include "ppapi/cpp/instance.h"
#include "remoting/client/audio_player.h"
+#include "remoting/proto/audio.pb.h"
namespace remoting {
-class AudioPacket;
-
class PepperAudioPlayer : public AudioPlayer {
public:
explicit PepperAudioPlayer(pp::Instance* instance);
virtual ~PepperAudioPlayer();
- // Returns true if successful, false otherwise.
- virtual bool Start() OVERRIDE;
-
virtual void ProcessAudioPacket(scoped_ptr<AudioPacket> packet) OVERRIDE;
- virtual bool IsRunning() const OVERRIDE;
-
private:
typedef std::list<AudioPacket*> AudioPacketQueue;
+ // Resets the audio player and starts the playback.
+ // Returns true on success.
+ bool ResetAudioPlayer(AudioPacket::SamplingRate sampling_rate);
+
// Function called by the browser when it needs more audio samples.
static void PepperAudioPlayerCallback(void* samples,
uint32_t buffer_size,
@@ -42,8 +40,11 @@ class PepperAudioPlayer : public AudioPlayer {
void FillWithSamples(void* samples, uint32_t buffer_size);
+ pp::Instance* instance_;
pp::Audio audio_;
+ AudioPacket::SamplingRate sampling_rate_;
+
// The count of sample frames per channel in an audio buffer.
uint32_t samples_per_frame_;
@@ -57,7 +58,7 @@ class PepperAudioPlayer : public AudioPlayer {
// The number of bytes from |queued_packets_| that have been consumed.
size_t bytes_consumed_;
- bool running_;
+ bool start_failed_;
DISALLOW_COPY_AND_ASSIGN(PepperAudioPlayer);
};

Powered by Google App Engine
This is Rietveld 408576698