Rename all of experiments_helper to variations_helper, including files, namespaces, and various fun…

Rename all of experiments_helper to variations_helper, including files, namespaces, and various function names.

TEST=none
BUG=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151357

[SteveT, 2012-07-21 06:26:41]

PTAL.

[SteveT, 2012-07-23 19:52:30]

Alexei: FYI.

[Alexei Svitkine (slow), 2012-07-23 19:56:17]

Any reason that we want a separate namespace than chrome_variations for this?

If not, I suggest using chrome_variations for the namespace and
variation_utils.[cc|h] for the filenames (to be consistent with other code that
prefs utils over helper).

Also, is there a way to rename the files such that history/diff is preserved?

[SteveT, 2012-08-07 15:37:36]

Okay, I've renamed the files to variations_util as you suggested, and changed
the variations_helper namespaces to chrome_variations so everything is unified.

PTAL.

[Alexei Svitkine (slow), 2012-08-07 17:12:54]

LGTM with a nit.

http://codereview.chromium.org/10795060/diff/16043/chrome/common/child_proces...
File chrome/common/child_process_logging.h (right):

http://codereview.chromium.org/10795060/diff/16043/chrome/common/child_proces...
chrome/common/child_process_logging.h:33: // The maximum size of an variation
chunk. This size was picked to be
Nit: "an" -> "a".

[SteveT, 2012-08-07 17:34:46]

Jesse: mind taking a look-see?

http://codereview.chromium.org/10795060/diff/16043/chrome/common/child_proces...
File chrome/common/child_process_logging.h (right):

http://codereview.chromium.org/10795060/diff/16043/chrome/common/child_proces...
chrome/common/child_process_logging.h:33: // The maximum size of an variation
chunk. This size was picked to be
On 2012/08/07 17:12:54, Alexei Svitkine wrote:
> Nit: "an" -> "a".

Done.

[SteveT, 2012-08-09 02:41:48]

Google. Show me photos of Jesse Doherty code reviewing my CL.

[jwd, 2012-08-10 14:00:45]

LGTM

[SteveT, 2012-08-10 14:06:06]

OWNERS review needed:
chrome/ and chrome/browser/autocomplete: Scott
chrome/browser/metrics: Ilya

PTAL - thanks!


Steve

[sky, 2012-08-10 15:39:09]

LGTM

[SteveT, 2012-08-13 17:59:59]

Re-pinging Ilya for OWNERS approval.

[Ilya Sherman, 2012-08-13 18:50:24]

LGTM.  Apologies for not getting to this review sooner; I was OOO on Friday +
this weekend...

https://chromiumcodereview.appspot.com/10795060/diff/27009/chrome/common/metr...
File chrome/common/metrics/variations_util.cc (right):

https://chromiumcodereview.appspot.com/10795060/diff/27009/chrome/common/metr...
chrome/common/metrics/variations_util.cc:159: experiment_strings[i] =
UTF8ToUTF16(base::StringPrintf(
nit: In the future, please split out changes like this to a separate CL; or if
you prefer to keep them in the same CL, mention them in the CL description.  In
the case that it were to cause any problems (shouldn't, in this case), it would
be very easy to miss this tweak in such a large patch.

[SteveT, 2012-08-13 19:57:43]

Thanks for look. No worries - was just repinging this thread today because I
figured it was buried under all your email thanks to the picnic :)

https://chromiumcodereview.appspot.com/10795060/diff/27009/chrome/common/metr...
File chrome/common/metrics/variations_util.cc (right):

https://chromiumcodereview.appspot.com/10795060/diff/27009/chrome/common/metr...
chrome/common/metrics/variations_util.cc:159: experiment_strings[i] =
UTF8ToUTF16(base::StringPrintf(
Sorry - I should have mentioned that I had to fix this as a result of a faulty
rebase. This change was made in an earlier (Android-related) CL that my rebase
missed somehow...

[commit-bot: I haz the power, 2012-08-13 19:57:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10795060/27009

[commit-bot: I haz the power, 2012-08-13 19:58:03]

Failed to apply patch for chrome/common/metrics/variations_util.cc:
While running patch -p0 --forward --force;
patching file chrome/common/metrics/variations_util.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 41.
Hunk #4 FAILED at 50.
Hunk #5 FAILED at 75.
Hunk #6 FAILED at 87.
Hunk #7 FAILED at 97.
Hunk #8 FAILED at 132.
Hunk #9 FAILED at 151.
Hunk #10 FAILED at 171.
10 out of 10 hunks FAILED -- saving rejects to file
chrome/common/metrics/variations_util.cc.rej

[commit-bot: I haz the power, 2012-08-13 20:19:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10795060/25015

[commit-bot: I haz the power, 2012-08-13 20:19:19]

Failed to apply patch for chrome/common/metrics/variations_util.cc:
While running patch -p0 --forward --force;
patching file chrome/common/metrics/variations_util.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 41.
Hunk #4 FAILED at 50.
Hunk #5 FAILED at 75.
Hunk #6 FAILED at 87.
Hunk #7 FAILED at 97.
Hunk #8 FAILED at 132.
Hunk #9 FAILED at 151.
Hunk #10 FAILED at 171.
10 out of 10 hunks FAILED -- saving rejects to file
chrome/common/metrics/variations_util.cc.rej

[commit-bot: I haz the power, 2012-08-13 20:52:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/stevet@chromium.org/10795060/25015

[commit-bot: I haz the power, 2012-08-13 20:52:41]

Failed to apply patch for chrome/common/metrics/variations_util.cc:
While running patch -p0 --forward --force;
patching file chrome/common/metrics/variations_util.cc
Hunk #1 FAILED at 2.
Hunk #2 FAILED at 31.
Hunk #3 FAILED at 41.
Hunk #4 FAILED at 50.
Hunk #5 FAILED at 75.
Hunk #6 FAILED at 87.
Hunk #7 FAILED at 97.
Hunk #8 FAILED at 132.
Hunk #9 FAILED at 151.
Hunk #10 FAILED at 171.
10 out of 10 hunks FAILED -- saving rejects to file
chrome/common/metrics/variations_util.cc.rej