Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 10795057: Chrome Endure tests forcefully clear ChromeDriver's node cache on each test iteration. (Closed)

Created:
8 years, 5 months ago by dennis_jeffrey
Modified:
8 years, 5 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, fdeng1, gregsimon
Visibility:
Public.

Description

Chrome Endure tests forcefully clear ChromeDriver's node cache on each test iteration. This is a temporary workaround to the problem of ChromeDriver continually growing a DOM node cache while Chrome Endure tests run (significantly impacting the results reported by Chrome Endure tests). There is a discussion with the WebDriver team about how to solve this problem in a better way within WebDriver itself, but for now this workaround should stabilize the Chrome Endure test results until a better solution is implemented. BUG=None TEST=Verified a Gmail Chrome Endure test did not reach steady state in DOM node count without this change, but did reach steady state with this change. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -6 lines) Patch
M chrome/test/functional/perf_endure.py View 8 chunks +29 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dennis_jeffrey
8 years, 5 months ago (2012-07-20 23:27:17 UTC) #1
Nirnimesh
LGTM
8 years, 5 months ago (2012-07-22 19:34:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/10795057/1
8 years, 5 months ago (2012-07-23 16:21:02 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 16:21:59 UTC) #4
Change committed as 147860

Powered by Google App Engine
This is Rietveld 408576698