Improve unit testing of socket API.

Improve unit testing of socket API.

Add socket_api_unittest.cc, which calls Socket API functions directly.
This skips the whole browser_tests setup that is relatively slow and
expensive. The current test merely validates the socket-type argument
handling, but the next phase will simulate blocking socket operations.

BUG=112902
TEST=see above


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148856 (then reverted)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149044

[asargent_no_longer_on_chrome, 2012-07-23 16:57:57]

LGTM

http://codereview.chromium.org/10795052/diff/1/chrome/browser/extensions/api/...
File chrome/browser/extensions/api/socket/socket_api.cc (right):

http://codereview.chromium.org/10795052/diff/1/chrome/browser/extensions/api/...
chrome/browser/extensions/api/socket/socket_api.cc:46: "It is likely you are
testing this API in an isolated environment.";
nit: I think this second line of error output is probably unnecessary. If you
want to keep it, a suggested change would be to something like "If you are using
this object in a test, you need to provide a socket manager implementation"

[commit-bot: I haz the power, 2012-07-23 19:12:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10795052/4001

[commit-bot: I haz the power, 2012-07-23 20:01:38]

Try job failure for 10795052-4001 (retry) on linux_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-07-23 20:55:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10795052/4001

[commit-bot: I haz the power, 2012-07-23 21:40:24]

Try job failure for 10795052-4001 (retry) on linux_rel for step "unit_tests".
It's a second try, previously, step "unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[miket_OOO, 2012-07-26 23:46:59]

OK, Antony, this is going to need a re-review for the most recent patch set.
Some are just merges of other folks' changes, but the important part is that in
the process of adding a working IO thread (which I determined didn't need a
message loop) to TestingProfile, more initialization code decided that it wanted
to run (specifically, code kicked off at
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/browser/browser_co...),
and this code expected a ChromeURLDataManagerBackend to exist, which up to this
point didn't in TestingProfile. Once I figured that out, the change was fairly
simple (though as you'll see, ChromeURLDataManagerBackend needs to be created on
the IO thread, so there's a bit of juggling there).

[commit-bot: I haz the power, 2012-07-27 20:21:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10795052/27002

[commit-bot: I haz the power, 2012-07-27 20:21:51]

Presubmit check for 10795052-27002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

[miket_OOO, 2012-07-27 20:56:26]

(resending with sky for OWNERS)

[darin (slow to review), 2012-07-27 22:49:42]

LGTM for gypi

[commit-bot: I haz the power, 2012-07-27 22:52:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10795052/27002

[commit-bot: I haz the power, 2012-07-28 00:14:17]

Change committed as 148856

[miket_OOO, 2012-07-30 18:05:04]

On 2012/07/28 00:14:17, I haz the power (commit-bot) wrote:
> Change committed as 148856

Reverted, fixed, recreated as http://codereview.chromium.org/10835038/, then
Mihai told me that it was OK to reopen a closed/committed issue. So I'm doing
that! Antony, please review the single-line change in test_extension_system.cc.

[asargent_no_longer_on_chrome, 2012-07-30 20:01:57]

lgtm

[commit-bot: I haz the power, 2012-07-30 20:13:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miket@chromium.org/10795052/20004

[commit-bot: I haz the power, 2012-07-30 22:08:03]

Change committed as 149044