Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10795050: Fix MediaSource code so it can handle HE-AAC content that uses implicit signalling. (Closed)

Created:
8 years, 5 months ago by acolwell GONE FROM CHROMIUM
Modified:
8 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Fix MediaSource code so it can handle HE-AAC content that uses implicit signalling. BUG=135674 TEST=Manual testing with the content in the bug. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147747

Patch Set 1 #

Patch Set 2 : Fix unittests #

Total comments: 4

Patch Set 3 : Added implicit SBR test #

Total comments: 6

Patch Set 4 : Address CR comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -27 lines) Patch
M media/filters/chunk_demuxer.cc View 1 2 3 4 chunks +17 lines, -5 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M media/mp4/aac.h View 1 2 3 2 chunks +8 lines, -2 lines 0 comments Download
M media/mp4/aac.cc View 1 2 3 7 chunks +28 lines, -11 lines 0 comments Download
M media/mp4/aac_unittest.cc View 1 2 3 chunks +17 lines, -3 lines 0 comments Download
M media/mp4/mp4_stream_parser.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/mp4/mp4_stream_parser.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M media/mp4/mp4_stream_parser_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
acolwell GONE FROM CHROMIUM
This patch allows the MediaSource to deal with HE-AAC content that uses implicit signalling. Implicit ...
8 years, 5 months ago (2012-07-20 21:35:57 UTC) #1
vrk (LEFT CHROMIUM)
LGTM modulo a few minor nits Is it worth adding a bug (pri-3) to do ...
8 years, 5 months ago (2012-07-20 23:08:48 UTC) #2
acolwell GONE FROM CHROMIUM
http://codereview.chromium.org/10795050/diff/7001/media/mp4/aac.h File media/mp4/aac.h (right): http://codereview.chromium.org/10795050/diff/7001/media/mp4/aac.h#newcode37 media/mp4/aac.h:37: // signalled in the mimetype. (ie mp4a.40.5 in the ...
8 years, 5 months ago (2012-07-20 23:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/10795050/13001
8 years, 5 months ago (2012-07-20 23:20:53 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-21 00:22:45 UTC) #5
Try job failure for 10795050-13001 (retry) on mac_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698