Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10795047: Request file icon at current device scale factor. (Closed)

Created:
8 years, 5 months ago by flackr
Modified:
8 years, 5 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, asanka, arv (Not doing code reviews), Randy Smith (Not in Mondays)
Visibility:
Public.

Description

Request file icon at current device scale factor. BUG=134802 TEST=Navigate to about:downloads in 2x mode. A 2x fileicon is requested. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=147858

Patch Set 1 #

Patch Set 2 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/downloads/downloads.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
flackr
PTAL, thanks! This should request the fileicon for the downloads page at the current device ...
8 years, 5 months ago (2012-07-20 19:06:01 UTC) #1
James Hawkins
lgtm
8 years, 5 months ago (2012-07-23 03:21:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/10795047/1
8 years, 5 months ago (2012-07-23 13:44:56 UTC) #3
commit-bot: I haz the power
8 years, 5 months ago (2012-07-23 13:45:00 UTC) #4
Presubmit check for 10795047-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/browser/resources/downloads/downloads.js:
  line 10: E0210: Missing docs for parameter: "node"
function showInline(node, isShow) {
                                ^^
  line 10: E0210: Missing docs for parameter: "isShow"
function showInline(node, isShow) {
                                ^^
  line 22: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 33: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 47: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 549: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 558: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 567: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 576: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 586: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 595: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 604: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 613: E0217: Missing @return JsDoc in function with non-trivial return
 */
 ^^
  line 683: E0210: Missing docs for parameter: "results"
function downloadsList(results) {
                              ^^
  line 697: E0210: Missing docs for parameter: "results"
function downloadUpdated(results) {
                                ^^

Presubmit checks took 1.6s to calculate.

Powered by Google App Engine
This is Rietveld 408576698