Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 10795045: Enable building V8 for Android on Mac (Closed)

Created:
8 years, 5 months ago by haitao.feng
Modified:
8 years, 5 months ago
Reviewers:
ulan, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Enable building V8 for Android on Mac Committed: https://code.google.com/p/v8/source/detail?r=12172

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download
M build/common.gypi View 1 2 3 chunks +7 lines, -3 lines 0 comments Download
M tools/android-build.sh View 1 2 4 chunks +17 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
Enable building V8 for Android on Mac. Basically choose the functions working on both Linux ...
8 years, 5 months ago (2012-07-20 14:57:04 UTC) #1
haitao.feng
Add some comments and refine the error message from android-build.sh. For the "-n" issue: "-n" ...
8 years, 5 months ago (2012-07-23 01:05:52 UTC) #2
haitao.feng
Remove tailing space and split long lines in build/common.gypi.
8 years, 5 months ago (2012-07-23 09:04:34 UTC) #3
Jakob Kummerow
LGTM, I'll land.
8 years, 5 months ago (2012-07-23 11:29:05 UTC) #4
Jakob Kummerow
8 years, 5 months ago (2012-07-23 11:31:14 UTC) #5
Actually, the line breaks in common.gypi in patch set 3 do not look good to me.
I've tried the same thing before, and it broke compilation on Windows. So I'll
have to undo those changes before landing.

Powered by Google App Engine
This is Rietveld 408576698