Issue 10795026: Add markers to app_host.exe and setup.exe to allow them to expose app commands via Google Update.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10795026: Add markers to app_host.exe and setup.exe to allow them to expose app commands via Google Update. (Closed)

Created:
8 years, 5 months ago by erikwright (departed)

Modified:
8 years, 5 months ago

Reviewers:
erikkay, tommi (sloooow) - chröme

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, grt+watch_chromium.org, grt (UTC plus 2), robertshield, Jói

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add markers to app_host.exe and setup.exe to allow them to expose app commands via Google Update. In http://codereview.chromium.org/10665002/ : setup.exe is used by the 'quick-enable-application-host' app command. app_host.exe is used by the 'install-application' app command. Pending Omaha changes will require executables referenced by app commands to include a resource marker. This CL adds that marker to the appropriate exes. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147552

Patch Set 1 #

Patch Set 2 : Improve comments. #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -25 lines)			Patch
A +	chrome/browser/extensions/app_host.rc	View	1	3 chunks	+6 lines, -25 lines	0 comments	Download
M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/installer/setup/setup.rc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tommi (sloooow) - chröme

Can you add a comment on where GOOGLEUPDATEAPPLICATIONCOMMANDS comes from? Lgtm.

8 years, 5 months ago (2012-07-19 05:57:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/10795026/1004

8 years, 5 months ago (2012-07-19 20:52:29 UTC) #3

Change committed as 147552

Expand Messages | Collapse Messages