Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Side by Side Diff: ui/gfx/gtk_native_view_id_manager.h

Issue 10795024: ui: Forward declare DefaultSingletonTraits in header files. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_ 5 #ifndef UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_
6 #define UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_ 6 #define UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/memory/singleton.h"
11 #include "base/synchronization/lock.h" 10 #include "base/synchronization/lock.h"
12 #include "ui/base/ui_export.h" 11 #include "ui/base/ui_export.h"
13 #include "ui/gfx/native_widget_types.h" 12 #include "ui/gfx/native_widget_types.h"
14 13
14 template <typename T> struct DefaultSingletonTraits;
15
15 typedef unsigned long XID; 16 typedef unsigned long XID;
16 struct _GtkPreserveWindow; 17 struct _GtkPreserveWindow;
17 18
18 // NativeViewIds are the opaque values which the renderer holds as a reference 19 // NativeViewIds are the opaque values which the renderer holds as a reference
19 // to a window. 20 // to a window.
20 // 21 //
21 // We could make NativeViewIds be the X id of the window. However, at the 22 // We could make NativeViewIds be the X id of the window. However, at the
22 // time when we need to tell the renderer about its NativeViewId, an XID isn't 23 // time when we need to tell the renderer about its NativeViewId, an XID isn't
23 // availible and it goes very much against the grain of the code to make it so. 24 // availible and it goes very much against the grain of the code to make it so.
24 // Also, we worry that GTK might choose to change the underlying X window id 25 // Also, we worry that GTK might choose to change the underlying X window id
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 // 129 //
129 // An XID will map to NULL, if there is an outstanding reference but the 130 // An XID will map to NULL, if there is an outstanding reference but the
130 // widget was destroyed. In this case, the destruction of the X window 131 // widget was destroyed. In this case, the destruction of the X window
131 // is deferred to the dropping of all references. 132 // is deferred to the dropping of all references.
132 std::map<XID, PermanentXIDInfo> perm_xid_to_info_; 133 std::map<XID, PermanentXIDInfo> perm_xid_to_info_;
133 134
134 DISALLOW_COPY_AND_ASSIGN(GtkNativeViewManager); 135 DISALLOW_COPY_AND_ASSIGN(GtkNativeViewManager);
135 }; 136 };
136 137
137 #endif // UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_ 138 #endif // UI_GFX_GTK_NATIVE_VIEW_ID_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698