Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 10795020: Using gdb_content_shell to attach to content_shell process directly. (Closed)

Created:
8 years, 5 months ago by michaelbai
Modified:
8 years, 5 months ago
Reviewers:
John Grabowski, Yaron
CC:
chromium-reviews
Visibility:
Public.

Description

Using gdb_content_shell to attach to content_shell process directly. - Attached to the running content_shell directly, don't need add any argument. - Added adb_shell function to remove the '\r' from the output, so the gdb_apk could find the correct process when both content_shell and sanboxed_process are running. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=147711

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -3 lines) Patch
M build/android/gdb_apk View 1 2 chunks +32 lines, -1 line 0 comments Download
M build/android/gdb_content_shell View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
michaelbai
8 years, 5 months ago (2012-07-18 23:35:20 UTC) #1
John Grabowski
LGTM http://codereview.chromium.org/10795020/diff/1/build/android/gdb_apk File build/android/gdb_apk (right): http://codereview.chromium.org/10795020/diff/1/build/android/gdb_apk#newcode20 build/android/gdb_apk:20: # Return: command's status Doc is a little ...
8 years, 5 months ago (2012-07-19 18:19:26 UTC) #2
michaelbai
http://codereview.chromium.org/10795020/diff/1/build/android/gdb_apk File build/android/gdb_apk (right): http://codereview.chromium.org/10795020/diff/1/build/android/gdb_apk#newcode20 build/android/gdb_apk:20: # Return: command's status On 2012/07/19 18:19:26, John Grabowski ...
8 years, 5 months ago (2012-07-20 18:52:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10795020/5001
8 years, 5 months ago (2012-07-20 18:53:00 UTC) #4
commit-bot: I haz the power
8 years, 5 months ago (2012-07-20 20:25:32 UTC) #5
Change committed as 147711

Powered by Google App Engine
This is Rietveld 408576698